Skip to content

Multisite: avoid Fatals on sites using WPMUDEV domain mapping#18323

Merged
jeherve merged 1 commit into
masterfrom
fix/domain-mapping-global-space
Jan 13, 2021
Merged

Multisite: avoid Fatals on sites using WPMUDEV domain mapping#18323
jeherve merged 1 commit into
masterfrom
fix/domain-mapping-global-space

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Jan 13, 2021

Changes proposed in this Pull Request:

Follow-up from #18061

Our changes in namespacing caused this issue, since we're relying on an external class here.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

This requires a bit of a setup, since you'd need to be using this plugin on a Multisite instance.

Once you've set that up, you shouldn't see any Fatals on your site.

Proposed changelog entry for your changes:

  • Multisite: avoid Fatals on sites using WPMUDEV domain mapping

Follow-up from #18061

Our changes in namespacing caused this issue, since we're relying on an external class here.
@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Focus] Multisite [Status] Needs Review This PR is ready for review. [Pri] High [Status] Needs Cherry-Pick labels Jan 13, 2021
@jeherve jeherve added this to the 9.3.1 milestone Jan 13, 2021
@jeherve jeherve self-assigned this Jan 13, 2021
@jetpackbot
Copy link
Copy Markdown
Collaborator

Scheduled Jetpack release: February 2, 2021.
Scheduled code freeze: January 25, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 6acc9c0

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 13, 2021
@jeherve jeherve merged commit 960fd0f into master Jan 13, 2021
@jeherve jeherve deleted the fix/domain-mapping-global-space branch January 13, 2021 17:04
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 13, 2021
jeherve added a commit that referenced this pull request Jan 13, 2021
…mapping (#18323)

Follow-up from #18061

Our changes in namespacing caused this issue, since we're relying on an external class here.
@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Jan 13, 2021

Cherry-picked to branch-9.3 in 2fb0c15

jeherve added a commit that referenced this pull request Jan 14, 2021
- Add entries for #18323 and #18314.
- Copy 9.3 to changelog.txt (I had forgotten to do it for that release).
- Update stable tag in readme.txt
jeherve added a commit that referenced this pull request Jan 14, 2021
- Add entries for #18323 and #18314.
- Copy 9.3 to changelog.txt (I had forgotten to do it for that release).
- Update stable tag in readme.txt
@brian-lamb-software-engineer
Copy link
Copy Markdown

Ive ran into this issue today, but the code already had its slash in there.

Fatal error: Uncaught Error: Class 'Automattic\Jetpack\Status\Host' not found in /home2/<obfuscated>/public_html/<obfuscated>.org/public/<obfuscated>/wp-content/plugins/jetpack/class.jetpack-gutenberg.php:1112

@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Nov 22, 2021

@brian-lamb-software-engineer You seem to be running into a different issue, not related to this PR.

Could you tell me more about your setup? What version of Jetpack do you use, did you experience the issue multiple times or only once when updating the plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Focus] Multisite [Pri] High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants