Skip to content

Beta: fix minor JS errors#20390

Merged
anomiex merged 6 commits into
masterfrom
fix/beta-elem-not-found
Jul 19, 2021
Merged

Beta: fix minor JS errors#20390
anomiex merged 6 commits into
masterfrom
fix/beta-elem-not-found

Conversation

@samiff
Copy link
Copy Markdown
Contributor

@samiff samiff commented Jul 16, 2021

Changes proposed in this Pull Request:

After PR: #20168

There were a few element not found errors since the plugin layout was adjusted; this PR cleans those errors up.

Does this pull request change what data or activity we track or use?

  • No.

Testing instructions:

  • After pulling down changes, the Beta plugin should function as expected still - try the different plugin sections while you have your browser console open.

After PR: #20168

There were a few element not found errors since the plugin layout was
adjusted; this PR cleans those errors up.
@samiff samiff added [Status] In Progress [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta labels Jul 16, 2021
@samiff samiff self-assigned this Jul 16, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 16, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Beta plugin:

  • Next scheduled release: August 3, 2021.
  • Scheduled code freeze: July 26, 2021.

> tools/project-version.sh -u 3.0.1-alpha plugins/beta
@samiff samiff added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 16, 2021
Comment thread projects/plugins/beta/src/admin/admin.js Outdated
Comment thread projects/plugins/beta/src/admin/admin.js Outdated
@anomiex anomiex added [Pri] Normal [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Pri] Low [Status] Needs Review This PR is ready for review. labels Jul 16, 2021
@samiff samiff added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 16, 2021
@anomiex anomiex added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 19, 2021
@anomiex anomiex merged commit c15c854 into master Jul 19, 2021
@anomiex anomiex deleted the fix/beta-elem-not-found branch July 19, 2021 16:19
@github-actions github-actions Bot added this to the beta/3.0.1 milestone Jul 19, 2021
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants