Skip to content

Boost: Add benefits interstitial #23482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haqadn merged 25 commits into from
Mar 30, 2022
Merged

Boost: Add benefits interstitial #23482

haqadn merged 25 commits into from
Mar 30, 2022

Conversation

@haqadn
Copy link
Contributor

@haqadn haqadn commented Mar 17, 2022 •
edited
Loading

Fixes #23318

Changes proposed in this Pull Request:

  • Useed svelte-navigator package for routing
  • Added benefits page
  • Added benefits page content and style
  • Activated button to purchase plan

Jetpack product discussion

pc9hqz-iD-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to 'Boost dashboard'
  • Add #/upgrade to the URL
  • Check the design on different screen sizes. dVyv3AO1fXG0gprXywMuMh-fi-2130%3A7342

image

@haqadn haqadn self-assigned this Mar 17, 2022
@matticbot
Copy link
Contributor

matticbot commented Mar 17, 2022

Caution: This PR has changes that must be merged to WordPress.com
Hello eAdnan007! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D76946-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Mar 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Boost plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 28, 2022.

@haqadn haqadn requested a review from a team as a code owner March 22, 2022 10:15
@haqadn
Copy link
Contributor Author

haqadn commented Mar 28, 2022

I also notice there are a few warnings in the browser console: image

These warnings are there because the router is pushing the props. If we register the props, we will have warnings about unused props on every build/watch as a warning. If we ignore it, it will not appear for the production build.

There's also some text at the bottom of the page ("Special introductory pricing...") which is missing.

Added

@haqadn
Copy link
Contributor Author

haqadn commented Mar 28, 2022

Be sure to check out the figma file in the i3 designs for box sizing: dVyv3AO1fXG0gprXywMuMh-fi-2130%3A7342

e.g.: The text "Optimize your website's performance" should be in a width-constrained box on it. If you click on elements in the figma, it shows you some CSS preview styles you can use as a starting location :)

I have kinda tangled this branch and #23319 by creating #23319 on top of this PR. The bounding box is correct in that branch as it is coming from a generic style which also modifes the structure of both cards. Can we merge this PR excluding this design fix and continue in the other PR?

@thingalon
Copy link
Member

thingalon commented Mar 29, 2022

These warnings are there because the router is pushing the props. If we register the props, we will have warnings about unused props on every build/watch as a warning. If we ignore it, it will not appear for the production build.

Fixed in 0d56820.

thingalon
thingalon previously approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@thingalon thingalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the understanding that more CSS updates to come in a future PR.

@thingalon thingalon force-pushed the add/boost-benefits-interstitial branch from c72a3f1 to 51645ae Compare March 30, 2022 08:08
thingalon
thingalon previously approved these changes Mar 30, 2022
View reviewed changes
@haqadn haqadn enabled auto-merge (squash) March 30, 2022 10:11
@haqadn haqadn merged commit f651a7a into master Mar 30, 2022
@haqadn haqadn deleted the add/boost-benefits-interstitial branch March 30, 2022 10:40
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

Great news! One last step: head over to your WordPress.com diff, D76946-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@haqadn
Copy link
Contributor Author

haqadn commented Mar 30, 2022

r242769-wpcom

@haqadn haqadn mentioned this pull request Mar 30, 2022
Closed
anomiex added a commit that referenced this pull request Mar 30, 2022
@anomiex
tools: Fix use of jq inside( array ) (#23702)
eaadc8f 
jq's `$arr1 | inside( $arr2 )`, when `$arr1` and `$arr2` are string
arrays, doesn't test for whether the elements of the input $arr1 are
members of $arr2. It tests for whether all strings in `$arr1` are
substrings of some string in `$arr2`, which is generally not the
behavior we want.

The same goes for `contains()`, but we're not using it on arrays
anywhere.

Instead, we can use `index()` to check for whether a string is in an
array.

Then fix Boost deps that the broken check didn't detect in #23482.
anomiex added a commit that referenced this pull request May 12, 2022
@anomiex
Remove pnpm hoisting for eslint
6b86505 
This involves moving the bits of eslint configuration that load plugins
or sharable configs into `tools/js-tools/eslintrc/`, so the plugins and
configs can be loaded relative to that directory instead of relative to
wherever the origin `.eslintrc.js` file happens to be.

This also drops the dep on `@sveltejs/eslint-config`, which hasn't been
used since #23482.

And for some reason projects/js-packages/shared-extension-utils/ had
both .eslintrc.js and .eslintrc.cjs, with identical content. So I
deleted one.
@anomiex anomiex mentioned this pull request May 12, 2022
Merged
anomiex added a commit that referenced this pull request May 17, 2022
@anomiex
Remove pnpm hoisting for eslint (#24355)
70cbc08 
This involves moving the bits of eslint configuration that load plugins
or sharable configs into `tools/js-tools/eslintrc/`, so the plugins and
configs can be loaded relative to that directory instead of relative to
wherever the origin `.eslintrc.js` file happens to be.

This also drops the dep on `@sveltejs/eslint-config`, which hasn't been
used since #23482.

And for some reason projects/js-packages/shared-extension-utils/ had
both .eslintrc.js and .eslintrc.cjs, with identical content. So I
deleted one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thingalon thingalon thingalon approved these changes

@karthikax karthikax Awaiting requested review from karthikax

Assignees

@haqadn haqadn

Labels

Admin Page React-powered dashboard under the Jetpack menu [Plugin] Boost A feature to speed up the site and improve performance. Touches WP.com Files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Boost] Add benefits interstitial

4 participants

@haqadn @matticbot @thingalon