Skip to content

Conversation

@pgk
Copy link
Contributor

@pgk pgk commented Apr 29, 2022

Based on this comment by @pablohoneyhoney

The text below the privacy selector could be dynamic and contextual to the selected privacy setting. The default state shall ideally be instructional of the interaction and also tell you what the site setting is currently.

Fixes #

Changes proposed in this Pull Request:

Jetpack product discussion

pxWta-1kj-p2#comment-5651

Testing instructions:

  • On your Jetpack site with VideoPress enabled, create a new post and add a new Video
  • Select the VideoPress block and change the privacy setting. The help messages change accordingly.

Does this pull request change what data or activity we track or use?

no

@pgk pgk added [Feature] VideoPress A feature to help you upload and insert videos on your site. [Block] VideoPress labels Apr 29, 2022
@pgk pgk requested review from jgcaruso, roundhill and thedebian April 29, 2022 14:46
@pgk pgk self-assigned this Apr 29, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello pgk! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D79810-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@pgk pgk added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Apr 29, 2022
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Apr 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 31, 2022.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 29, 2022
Copy link
Contributor

@thedebian thedebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well 👍

@pgk pgk added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels May 4, 2022
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Review This PR is ready for review. labels May 4, 2022
@pgk pgk merged commit 826ac44 into master May 5, 2022
@pgk pgk deleted the add/videopress-privacy-help-message branch May 5, 2022 13:59
@github-actions github-actions bot added this to the jetpack/11.0 milestone May 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Great news! One last step: head over to your WordPress.com diff, D79810-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 5, 2022
@pgk
Copy link
Contributor Author

pgk commented May 9, 2022

r245278-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] VideoPress [Feature] VideoPress A feature to help you upload and insert videos on your site. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants