Sharing: Use an unfiltered post permalink for all sharing links#2420
Merged
Conversation
Fixes https://wordpress.org/support/topic/pinterest-sharing-button-not-working Create a new function, get_process_request_url Use instead of get_share_url for non-official styles as get_permalink ensures that process_request will be executed more reliably, in the case that the filtered URL uses a service that strips query parameters.
jeherve
added
Enhancement
Member
Author
|
cc @aduth |
Member
|
An effective clarification to why I wasn't able to find any cases of |
Member
Author
Contributor
|
I was unable to reproduce the original issue, but the code looks fine, and @aduth signed off, so I'm going to go ahead and accept it |
samhotchkiss
added a commit
that referenced
this pull request
Aug 25, 2015
Sharing: Use an unfiltered post permalink for all sharing links
Member
Author
For reference, one can reproduce the issue by customizing the shared permalink thanks to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://wordpress.org/support/topic/pinterest-sharing-button-not-working and a Pinterest issue that was introduced in 888a5ae
Create a new function,
get_process_request_urlUse instead of
get_share_urlfor non-official styles asget_permalinkensures thatprocess_requestwill be executed more reliably, in the case that the filtered URL uses a service that strips query parameters.