Skip to content

Conversation

@retrofox
Copy link
Contributor

@retrofox retrofox commented May 6, 2022

This PR removes the hardcoded Security bundle data, replacing them with data provided by wpcom side.
It makes the implementation more reliable and consistent. Easier to maintain.

In a previous PR, we've exposed the securityBundle by the useProtectData() hook. The securityBundle is propagated from the backend to the client via the jetpackProtectInitialState global var. This data is requested to the wpcom side, hitting a proper endpoint.

Fixes #

Changes proposed in this Pull Request:

  • Protect: render Security component with dynamic data.
  • Clean mock data
  • Improve the Interstitial story adding mock data.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Test with Storybook

image

Test in Protect overview

  • Disconnect your testing site to see the interstitial page
  • Confirm you see the Security card properly

image

before after pricing
Screen Shot 2022-05-06 at 12 14 20 PM Screen Shot 2022-05-06 at 12 15 29 PM image

@retrofox retrofox added [Status] Needs Review This PR is ready for review. [Size] M [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. labels May 6, 2022
@retrofox retrofox requested a review from a team May 6, 2022 15:25
@retrofox retrofox self-assigned this May 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Protect plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 30, 2022.

Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well

@retrofox retrofox merged commit a9ee1a5 into master May 6, 2022
@retrofox retrofox deleted the update/protect-secutiry-bundle-data-ui branch May 6, 2022 17:51
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Size] M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants