Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented May 11, 2022

A partial PHPCS for class.jetpack.php. Restarting making slow/steady progress on this file. See #21952

Changes proposed in this Pull Request:

  • General PHPCS

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Verify the changes are not problematic.

@kraftbj kraftbj added this to the jetpack/11.0 milestone May 11, 2022
@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels May 11, 2022
@kraftbj kraftbj self-assigned this May 11, 2022
@kraftbj kraftbj requested a review from a team May 11, 2022 20:31
@kraftbj kraftbj enabled auto-merge (squash) May 11, 2022 20:32
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label May 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 31, 2022.

$notice .= ' ' . self::development_mode_trigger_text();

echo '<div class="updated" style="border-color: #f0821e;"><p>' . $notice . '</p></div>';
echo '<div class="updated" style="border-color: #f0821e;"><p>' . $notice . '</p></div>'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- All provided text.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own future reference, do we have any guidelines for choosing between ignoring the OutputNotEscaped and using some variety of wp_kses()?

@kraftbj kraftbj merged commit c740f05 into master May 11, 2022
@kraftbj kraftbj deleted the phpcs/jetpack-class-more branch May 11, 2022 20:45
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants