Skip to content

PHPCS: Tiled Gallery #24352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sdixon194 merged 22 commits into from
May 16, 2022
Merged

PHPCS: Tiled Gallery #24352

sdixon194 merged 22 commits into from
May 16, 2022

Conversation

@sdixon194
Copy link
Contributor

@sdixon194 sdixon194 commented May 12, 2022

Fixes #21977

Changes proposed in this Pull Request:

  • PHPCS changes for the tiled gallery.

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Proof, test.

@sdixon194 sdixon194 added the [Status] Needs Review This PR is ready for review. label May 12, 2022
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. labels May 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 31, 2022.

jeherve
jeherve reviewed May 13, 2022
View reviewed changes
projects/plugins/jetpack/modules/tiled-gallery/tiled-gallery/tiled-gallery-layout.php
*
* @param array $context - the context.
*/
public function HTML( $context = array() ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
Copy link
Member

@jeherve jeherve May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth renaming the method here and where it's being used, so we can get rid of the phpcs ignore?

Copy link
Contributor Author

@sdixon194 sdixon194 May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried because all of the child classes also define HTML (but for some reason, the sniff only complains about the parent class here), so I think I'd have to update those too. I was simply afraid I miss renaming everything. If you think it's worth it, I can give it a go!

Copy link
Member

@jeherve jeherve May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that in a follow-up PR I suppose. 👍

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels May 13, 2022
anomiex
anomiex reviewed May 13, 2022
View reviewed changes
sdixon194 and others added 5 commits May 13, 2022 10:45
@sdixon194 @jeherve
Update projects/plugins/jetpack/modules/tiled-gallery/tiled-gallery.php
41321e3 
Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
@sdixon194 @anomiex
Apply suggestions from code review
deee5ff 
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@sdixon194 @anomiex
Apply suggestions from code review
a36921b 
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@sdixon194 @anomiex
Update projects/plugins/jetpack/modules/tiled-gallery/tiled-gallery/t…
8f0b48d 
…iled-gallery-shape.php

Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@sdixon194 @anomiex
Apply suggestions from code review
ebb12cc 
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@sdixon194 sdixon194 added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 13, 2022
@anomiex
Copy link
Contributor

anomiex commented May 13, 2022

For the record, I'm happy now. I see you and Jeremy still have an open item of discussion.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 16, 2022
@matticbot
Copy link
Contributor

matticbot commented May 16, 2022

Caution: This PR has changes that must be merged to WordPress.com
Hello sdixon194! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D80880-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@sdixon194 sdixon194 merged commit 9803e00 into master May 16, 2022
@sdixon194 sdixon194 deleted the phpcs/tiled-galleries branch May 16, 2022 16:44
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 16, 2022
@github-actions github-actions bot added this to the jetpack/11.0 milestone May 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2022

Great news! One last step: head over to your WordPress.com diff, D80880-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@sdixon194
Copy link
Contributor Author

sdixon194 commented May 16, 2022

r245730-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve left review comments

@anomiex anomiex anomiex left review comments

@kraftbj kraftbj kraftbj approved these changes

Assignees

@sdixon194 sdixon194

Labels

[Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Janitorial

Projects

None yet

Milestone

jetpack/11.0

Development

Successfully merging this pull request may close these issues.

PHPCS: Tiled Galleries

6 participants

@sdixon194 @anomiex @matticbot @kraftbj @jeherve