Skip to content

Conversation

@leogermani
Copy link
Contributor

@leogermani leogermani commented May 12, 2022

Changes proposed in this Pull Request:

  • Cache empty results for a shorter period of time
  • Add tests :)
  • Fix a small bug in get_all_vulnerabitlities()

Jetpack product discussion

1202064326332560-as-1202246145491819

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Set your response type as empty
  • Connect Protect and load the page
  • Check your jetpack_protect_status_time option and verify it is a timestamp for only 5 minutes in the future

@leogermani leogermani added the [Status] Needs Review This PR is ready for review. label May 12, 2022
@leogermani leogermani self-assigned this May 12, 2022
@github-actions github-actions bot added the [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. label May 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Protect plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 30, 2022.

@singerb singerb requested a review from a team May 12, 2022 20:21
retrofox
retrofox previously approved these changes May 13, 2022
Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Confirmed the timestamp is five minutes when empty state:

> jetpack docker wp option get jetpack_protect_status_time
1652439562

Screen Shot 2022-05-13 at 6 54 35 AM

complete status

And it's twelve hours when complete:

jetpack docker wp option get jetpack_protect_status_time
1652482357

Screen Shot 2022-05-13 at 6 52 56 AM

@retrofox retrofox added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 13, 2022
@leogermani
Copy link
Contributor Author

I love the illustrated testing report! Thanks.

There are some failing tests in some PHP versions I'll have to fix

@leogermani leogermani force-pushed the add/shorter-cache-for-empty-responses branch from 70bc7d4 to d1110e1 Compare May 13, 2022 15:44
@leogermani leogermani added [Status] Needs Review This PR is ready for review. and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 13, 2022
@leogermani leogermani merged commit 6f8db33 into master May 13, 2022
@leogermani leogermani deleted the add/shorter-cache-for-empty-responses branch May 13, 2022 21:07
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants