-
Notifications
You must be signed in to change notification settings - Fork 851
Protect: Cache empty results for a shorter period of time #24353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Protect plugin:
|
retrofox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I love the illustrated testing report! Thanks. There are some failing tests in some PHP versions I'll have to fix |
70bc7d4 to
d1110e1
Compare


Changes proposed in this Pull Request:
Jetpack product discussion
1202064326332560-as-1202246145491819
Does this pull request change what data or activity we track or use?
Testing instructions:
emptyjetpack_protect_status_timeoption and verify it is a timestamp for only 5 minutes in the future