Skip to content

Conversation

@retrofox
Copy link
Contributor

@retrofox retrofox commented May 12, 2022

This PR takes advantage of the data provided by My Jetpack to remove the mock product data.

This is a follow-up of #24347.

Fixes #

Changes proposed in this Pull Request:

  • Protect: use data provided by My Jetpack to render Product offer

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Should not be any visual change in the UI, but anyway:

Using storybook

image

Using Protect plugin page

  • Disconnect the site
  • Go to Protect plugin page
  • Confirm the data shown there is right

image

  • Open the dev console
  • Get the protect data using the selector:
wp.data.select( 'jetpack-protect' ).getProductData()

image


@retrofox retrofox added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Size] M [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. labels May 12, 2022
@retrofox retrofox requested review from a team and leogermani May 12, 2022 23:01
@retrofox retrofox self-assigned this May 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Protect plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 30, 2022.

@retrofox retrofox force-pushed the update/protect-remove-product-mock-data branch from 4a0e012 to 60e7b2f Compare May 16, 2022 14:40
@samiff samiff self-requested a review May 16, 2022 17:54
Copy link
Contributor

@samiff samiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well for me 👍

@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 16, 2022
@retrofox
Copy link
Contributor Author

retrofox commented May 16, 2022 via email

@retrofox retrofox merged commit 1613d23 into master May 17, 2022
@retrofox retrofox deleted the update/protect-remove-product-mock-data branch May 17, 2022 02:18
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Size] M [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants