Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented May 13, 2022

Supports #21952

Changes proposed in this Pull Request:

  • More various PHPCS. Just chipping away and not wanting things to get stale with such a large file. This one is mainly "simple" things.

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Review manually, run Jetpack.

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label May 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 31, 2022.

@kraftbj kraftbj self-assigned this May 13, 2022
@kraftbj kraftbj added this to the jetpack/11.0 milestone May 13, 2022
@kraftbj kraftbj marked this pull request as ready for review May 13, 2022 15:56
@sdixon194 sdixon194 added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels May 17, 2022
@sdixon194
Copy link
Contributor

Looks good to me, just the above suggestion from Brad.

Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 17, 2022
@kraftbj kraftbj requested a review from sdixon194 May 17, 2022 21:26
@kraftbj kraftbj enabled auto-merge (squash) May 17, 2022 21:26
@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 17, 2022
@kraftbj kraftbj merged commit bada757 into master May 17, 2022
@kraftbj kraftbj deleted the phpcs/class-jetpack branch May 17, 2022 23:05
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants