Modules: Make activate() method Jetpack-the-plugin agnostic

[dereksmart]

It's an ugly refactor, stuffs Jetpack-specific logic into a class_exists check. However it allows standalone plugins to use the Modules()->activate() method.

Changes proposed in this Pull Request:

• Refactors Modules()->activate() to execute Jetpack-specific logic only when Jetpack is present.
• Updates Search activation method to use it directly.
• Updates Search deactivation method to use the Module class method - there was no Jetpack-specific logic there.

Jetpack product discussion

• p1652392614473149-slack-CBG1CP4EN
• pdWQjU-o-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Set up a site with Search plan
• Enable/disable the Search setting from the Search plugin when Jetapck is not active.
• When activating Jetpack, make sure the status is accurate.

Make sure that activating the modules from Jetpack also works:

• From the settings UI
• From /wp-admin/admin.php?page=jetpack_modules
• From wp-cli
• From Calypso settings

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

[kangzj]

Hi @dereksmart, thanks for fixing this! Really appreciate it - this would save us hours if not days exploring! 👍

It works as described. I left a question but which doesn't seem a blocker to me 💯

[kangzj]

I'm wondering how Search plugin would claim it needs connection by using the Modules class?

[kangzj]

This doesn't seems to matter a lot for standalone plugins tho, since if site is not connected, the search dashboard wouldn't be shown anyway.

[kangzj]

Hey @dereksmart any plan to merge this? I do think better to have more people testing it before merging.

Hey @Automattic/jetpack-search peeps, if you have some time, would you mind spinning of this PR?

[dereksmart]

hey @kangzj sorry I was waiting some to see if it'd help Social plugin with their issue. It doesn't really, but it does get it a bit closer as they were hitting the file checks anyway. I'll clean it up tomorrow and get more testing so we can merge and can work on the rest in follow-ups. Started a branch in add/debug-helper-modules and hoping to provide some easier ways to debug these modules via the debug plugin.

[kangzj]

Thanks for your kind reply. This doesn't block Search anyway, take your time 💯

[leogermani]

I've tested in different scenarios... tested integrating it with My Jetpack and also tested for regressions within the Jetpack plugin and it looks good to me