Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented May 18, 2022

Changes proposed in this Pull Request:

  • This reverts removes problematic code while we investigate an incident on the Atomic platform.

Jetpack product discussion

p9o2xV-26K-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Still investigating how to duplicate the issues thrown.

@kraftbj kraftbj added this to the jetpack/11.0 milestone May 18, 2022
@kraftbj kraftbj added [Pri] BLOCKER [Status] Needs Review This PR is ready for review. [Type] Bug When a feature is broken and / or not performing as intended labels May 18, 2022
@kraftbj kraftbj requested review from a team, bisko and fgiannar and removed request for a team May 18, 2022 19:25
@github-actions github-actions bot added [Package] Backup [Package] Sync [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin labels May 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 31, 2022.

Backup plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 30, 2022.

Search plugin:

  • Next scheduled release: May 30, 2022.
  • Scheduled code freeze: May 23, 2022.

Social plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 30, 2022.

Starter Plugin plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 30, 2022.

Protect plugin:

  • Next scheduled release: June 7, 2022.
  • Scheduled code freeze: May 30, 2022.

bisko
bisko previously approved these changes May 18, 2022
@kraftbj kraftbj enabled auto-merge (squash) May 18, 2022 19:36
@kraftbj kraftbj merged commit 70c782e into master May 18, 2022
@kraftbj kraftbj deleted the revert/dedicated-sync branch May 18, 2022 19:48
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Backup [Package] Sync [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants