Skip to content

Conversation

@pablinos
Copy link
Contributor

Changes proposed in this Pull Request:

Now we have the final design for the icon, this PR updates the SVG to
the optimised verison.

Jetpack product discussion

p1HpG7-g1B-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Run storybook cd projects/js-packages/storybook && pnpm run storybook:dev
  • Head to Components -> Icons and check that the Social icon looks ok.

image

Now we have the final design for the icon, this PR updates the SVG to
the optimised verison.
@pablinos pablinos requested a review from a team May 24, 2022 21:32
@pablinos pablinos self-assigned this May 24, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello pablinos! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D81445-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the RNA label May 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Contributor

@danielpost danielpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thought here (looks a little big) but works well!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 25, 2022
@jeherve jeherve enabled auto-merge (squash) May 25, 2022 09:46
@jeherve jeherve merged commit 61ba2d5 into master May 25, 2022
@jeherve jeherve deleted the update/social-icon branch May 25, 2022 09:46
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D81445-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 25, 2022
@pablinos
Copy link
Contributor Author

r246400-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants