Skip to content

Conversation

@adimoldovan
Copy link
Member

@adimoldovan adimoldovan commented May 25, 2022

Changes proposed in this Pull Request:

Send a notification on Slack when block performance tests are failing.

Jetpack product discussion

1156386383419466-as-1202291410523594/f

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • See test notification: p1653484752622569-slack-C1Y1F7ZM1

@adimoldovan adimoldovan self-assigned this May 25, 2022
@github-actions github-actions bot added Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests labels May 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@adimoldovan adimoldovan marked this pull request as ready for review May 25, 2022 13:43
@adimoldovan adimoldovan added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels May 25, 2022
@adimoldovan adimoldovan enabled auto-merge (squash) May 25, 2022 13:50
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@adimoldovan adimoldovan merged commit 46fb9f8 into master May 25, 2022
@adimoldovan adimoldovan deleted the tests/slack-notification-for-performance-tests-failure branch May 25, 2022 14:47
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants