-
Notifications
You must be signed in to change notification settings - Fork 847
Remove the 'Check for Spam' button from the feedback page #27445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run |
CGastrell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good on .com, AT and self hosted ![]()
digitalwaveride
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
I don't understand this change. Did we remove the possibility to re-check submissions for spam? What happens if I only enabled Akismet after getting 1000 spam-y responses? How do we get this functionality back? |
|
Apologies, that we didn't communicate in the PRs clearly. We discussed in one of our team calls the functionality of the button and decided not to hide the "check spam" button completely, but bring it to the bottom of the table. The integration of the button at the bottom of the table was planned to be done in a different PR though. Sorry for not mentioning that in the PR! For background: As on top of the table things are very busy, and the "frequency" that this button might be used, is very low, it doesn't feel like it deserves this very prominent integration on top of the table. We discussed two ideas, putting the check spam option into the "bulk dropdown" or putting the button at the bottom of the table. |
* Revert "Remove the 'Check for Spam' button from the feedback page (#27445)" This reverts commit 83af256. * Reposition 'Check for Spam' button to under the feedback table * Fix check for spam button alignment on the feedback page * Add changelog * Fix JS lint issue Co-authored-by: Osk <oskosk@users.noreply.github.com>
Fixes #27444
Changes proposed in this Pull Request:
This PR removes the 'Check for Spam' button from the top of the table on the feedback page when Akismet is enabled.
Other information:
Jetpack product discussion
pcsBup-oK-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions: