Skip to content

Conversation

@ice9js
Copy link
Contributor

@ice9js ice9js commented Nov 16, 2022

Fixes #27444

Changes proposed in this Pull Request:

This PR removes the 'Check for Spam' button from the top of the table on the feedback page when Akismet is enabled.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

pcsBup-oK-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Make sure you have Akismet is installed and active on your test site.
  • Go to WP Admin -> Feedback.
  • There should no longer be a 'Check for Spam' button at the top of the feedback responses table.

@ice9js ice9js added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Nov 16, 2022
@ice9js ice9js self-assigned this Nov 16, 2022
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Contact Form labels Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: December 6, 2022.
  • Scheduled code freeze: November 28, 2022.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/remove-check-for-spam-button to get started. More details: p9dueE-5Nn-p2

Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on .com, AT and self hosted :shipit:

Copy link

@digitalwaveride digitalwaveride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ice9js ice9js added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Nov 17, 2022
@bindlegirl bindlegirl added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 18, 2022
@ice9js ice9js merged commit 83af256 into trunk Nov 18, 2022
@ice9js ice9js deleted the update/remove-check-for-spam-button branch November 18, 2022 19:40
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 18, 2022
@github-actions github-actions bot added this to the jetpack/11.5.2 milestone Nov 18, 2022
@oskosk
Copy link
Contributor

oskosk commented Nov 18, 2022

I don't understand this change. Did we remove the possibility to re-check submissions for spam? What happens if I only enabled Akismet after getting 1000 spam-y responses? How do we get this functionality back?

@digitalwaveride
Copy link

Apologies, that we didn't communicate in the PRs clearly.

We discussed in one of our team calls the functionality of the button and decided not to hide the "check spam" button completely, but bring it to the bottom of the table.

The integration of the button at the bottom of the table was planned to be done in a different PR though. Sorry for not mentioning that in the PR!

For background:

As on top of the table things are very busy, and the "frequency" that this button might be used, is very low, it doesn't feel like it deserves this very prominent integration on top of the table.

We discussed two ideas, putting the check spam option into the "bulk dropdown" or putting the button at the bottom of the table.
The "bulk dropdown" option had so several downsides on the UX and implementation, so went with bringing "Check Spam" to the bottom.

ice9js added a commit that referenced this pull request Nov 23, 2022
* Revert "Remove the 'Check for Spam' button from the feedback page (#27445)"

This reverts commit 83af256.

* Reposition 'Check for Spam' button to under the feedback table

* Fix check for spam button alignment on the feedback page

* Add changelog

* Fix JS lint issue

Co-authored-by: Osk <oskosk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove 'Check For Spam' button from the Feedback screen in WP Admin

7 participants