SoundCloud Widget: avoid undefined when Visual option is not set

[jeherve]

Reported here:
https://wordpress.org/support/topic/shortcode-embeds-undefined-index?replies=1&view=all

[zinigor]

Can you be more verbose about why you changed the logic here?

[jeherve]

The previous logic didn't appear to work at all in my tests. The SoundCloud widget always used the Visual appearance, regardless of your settings.

I'd be happy to rework on that logic completely though, to make it more readable maybe?

[zinigor]

No, I was just curious to know the reason. Now that I have tested the visual/previous player, I realize there was a problem here, thanks for fixing it!

[dereksmart]

I can't reproduce this issue on master using the OP's shortcode or various versions of it. No notices in error lor or on page. Am I missing something?

[jeherve]

@dereksmart It's been a while since I tested this, but I seem to recall that I could trigger the notice by playing with the iFrame parameter in the shortcode.

[dereksmart]

/shrug I can't break it. If you have a broken instance, can you paste the exact shortcode you're using?

[jeherve]

@dereksmart I still haven't been able to reproduce on any of my test sites. Here is the shortcode used by the site owner who reported the issue:

[soundcloud url="https://api.soundcloud.com/tracks/122514535" params="color=ff6600&auto_play=false&show_artwork=true" width="100%" height="166" iframe="true" /]

[dereksmart]

Closing as no one can reproduce anymore. Please reopen if that changes or we get more reports.