Launchpad: Adjust Logstash ref to fix fatal on WoA sites

[sixhours]

Fixes #31283

Proposed changes:

• Wrap references to Logstash in an IS_WPCOM check to prevent fatal errors on WoA sites, and return WP_Error if task initialization fails for any site.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Create a WoA developer site if you don't have one already
• Use the Jetpack Beta Tester plugin to apply this patch to your WoA site
• Alternatively, apply this patch to the site via SSH/rsync or SFTP; you may need to check out this patch locally and overwrite the entire contents of the /launchpad directory, not just this patched file. You'll find the files in /wpcomsh/vendor/automattic/jetpack-mu-wpcom/src/features/launchpad/
• tail -F /tmp/php-errors on the WoA site
• Ensure you no longer see fatal errors like the following:

[github-actions]

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/woa-fatal-launchpad

to get started. More details: p9dueE-5Nn-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Mu Wpcom plugin:

• Next scheduled release: July 4, 2023.
• Scheduled code freeze: June 26, 2023.

[samiff]

If you still wanted to do this on simple wpcom for now, could you use a file_exists check before the require and function_exists check in the catch?

[sixhours]

Is the IS_WPCOM global defined on Atomic sites? That might be a simpler check... looks like that's what we do in launchpad.php, though that's also filtering by blog ID.

[samiff]

Ah yes, if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) would work for checking simple wpcom sites. That constant shouldn't be on Atomic sites, it's how the status package checks for example:

jetpack/projects/packages/status/src/class-host.php

Lines 61 to 68 in b5e0513

	/**
	* Determine if this is a Simple platform site.
	*
	* @return bool
	*/
	public function is_wpcom_simple() {
	return Constants::is_defined( 'IS_WPCOM' ) && true === Constants::get_constant( 'IS_WPCOM' );
	}

[samiff]

Verified this will correct the issue. If we want to merge as-is, will need to add a changelog and fix the lint error about empty catch block.

[sixhours]

I'm headed out for the weekend, @nelsonec87 or @andres-blanco please feel free to commandeer this PR and get it shipped to avoid blocking deployment to WoA. Thank you!!

[samiff]

Looks good, thanks for the quick fix @sixhours 🙇