-
Notifications
You must be signed in to change notification settings - Fork 851
CLI: Refactor jetpack changelog command to pass directly to changelogger #34216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
|
Okay, think this is good for another look 👍 |
anomiex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One bug found, and a bunch of suggestions.
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
|
I think this is good for hopefully one last look 👍 |
anomiex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One bug found, and one suggestion
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
anomiex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go for it!
Prior to #34216, passing a project and the `-s`, `-t`, and `-e` options to `jetpack changelog add` would skip the prompts and just run changelogger. Restore that behavior.
Prior to #34216, passing a project and the `-s`, `-t`, and `-e` options to `jetpack changelog add` would skip the prompts and just run changelogger. Restore that behavior.
Proposed changes:
This refactor lets us massage the changelog entries for the monorepo via the CLI, instead of just calling the changelogger in interactive mode. This will let us add any custom questions or data we want without interfering with the public package.
This doesn't add the new prompt for if it's a user facing change, as discussed in #34058
It just lays the groundwork to do that.
Other information:
Jetpack product discussion
Internal ref: p1699566741898429-slack-C05Q5HSS013
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Make sure the
jetpack changelog addcommand still works as expected:jetpack changelog addshould find the project and let you add a changelog file to it.