Skip to content

Conversation

@sdixon194
Copy link
Contributor

@sdixon194 sdixon194 commented Nov 20, 2023

Proposed changes:

This refactor lets us massage the changelog entries for the monorepo via the CLI, instead of just calling the changelogger in interactive mode. This will let us add any custom questions or data we want without interfering with the public package.

This doesn't add the new prompt for if it's a user facing change, as discussed in #34058

It just lays the groundwork to do that.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Internal ref: p1699566741898429-slack-C05Q5HSS013

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Make sure the jetpack changelog add command still works as expected:

  • `jetpack changelog add / should add a changelog file to the specified project
  • If you make a change to a project, just running jetpack changelog add should find the project and let you add a changelog file to it.
  • If you make changes to multiple projects, you should have the option to add the same changelog file to all of them
  • It should give the appropriate changelog types for projects with specified changelog types, like jetpack.

@sdixon194 sdixon194 requested a review from anomiex November 20, 2023 20:45
@github-actions github-actions bot added the [Tools] Development CLI The tools/cli to assist during JP development. label Nov 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 20, 2023
@sdixon194 sdixon194 added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 20, 2023
@sdixon194
Copy link
Contributor Author

Okay, think this is good for another look 👍

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bug found, and a bunch of suggestions.

sdixon194 and others added 6 commits November 27, 2023 11:14
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@sdixon194
Copy link
Contributor Author

I think this is good for hopefully one last look 👍

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bug found, and one suggestion

sdixon194 and others added 2 commits November 27, 2023 16:25
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it!

@sdixon194 sdixon194 merged commit 0bfd2ea into trunk Nov 28, 2023
@sdixon194 sdixon194 deleted the update/changelogger-build-command branch November 28, 2023 15:56
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 28, 2023
anomiex added a commit that referenced this pull request Jan 10, 2024
Prior to #34216, passing a project and the `-s`, `-t`, and `-e` options
to `jetpack changelog add` would skip the prompts and just run
changelogger. Restore that behavior.
anomiex added a commit that referenced this pull request Jan 10, 2024
Prior to #34216, passing a project and the `-s`, `-t`, and `-e` options
to `jetpack changelog add` would skip the prompts and just run
changelogger. Restore that behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Tools] Development CLI The tools/cli to assist during JP development.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants