-
Notifications
You must be signed in to change notification settings - Fork 850
Improving likes: Update Like button "likers" dialog design #34308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
76e6197 to
f15ca34
Compare
TimBroddin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine!
* Add RTL support * Add changelog * Fix position
phcp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Code looks good and works as expected.
Resolves Automattic/wp-calypso#84424.
Proposed changes:
Other information:
Jetpack product discussion
Project thread: pdDOJh-2Ht-p2#comment-2057
Does this pull request change what data or activity we track or use?
No, it does not.
Testing instructions:
likes_new_layoutfeature flag, e.g. by addingadd_filter( 'likes_new_layout', '__return_true' );somewhere in the Jetpack plugin (before the feature flag check is executed). For the matter of testing this PR, you can add it toprojects/plugins/jetpack/modules/likes/jetpack-likes-master-iframe.phplike this:rsyncto sync the built files to your WoA or Jetpack / Jurassic Ninja site.