Skip to content

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Nov 27, 2023

Resolves Automattic/wp-calypso#84424.

Proposed changes:

  • update the Like button "likers" dialog design (similar changes as were introduced to Simple sites in D129905-code already)

Markup on 2023-11-27 at 15:56:35

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Project thread: pdDOJh-2Ht-p2#comment-2057

Does this pull request change what data or activity we track or use?

No, it does not.

Testing instructions:

  1. Please test with both WoA and Jetpack sites. Syncing the changes to WPCOm should not cause any issues with Simple sites.
  2. Check out the PR branch and enable the likes_new_layout feature flag, e.g. by adding add_filter( 'likes_new_layout', '__return_true' ); somewhere in the Jetpack plugin (before the feature flag check is executed). For the matter of testing this PR, you can add it to projects/plugins/jetpack/modules/likes/jetpack-likes-master-iframe.php like this:

Markup on 2023-11-27 at 15:53:44

  1. Use rsync to sync the built files to your WoA or Jetpack / Jurassic Ninja site.
  2. The test site post needs to have a number of likers for you to be able to follow the next steps. If you don't have enough likers, let me know and I can give you some. 🙂 Or, you can consider using a small hack mentioned on the bottom of this patch description: D129834-code.
  3. Click on the "X likes" link and review the design (fJZ60vrt8ZNJwL2TPPM106-fi-156%3A5550) of the dialog that will open.
  4. If the feature flag is disabled, there should be no regressions, i.e. the site should use the old / current Like design.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/like-widget-dialog-new-desgin branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/like-widget-dialog-new-desgin
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Likes [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Nov 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for December 5, 2023 (scheduled code freeze on November 28, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 27, 2023
@ivan-ottinger ivan-ottinger added [Status] In Progress and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 27, 2023
@ivan-ottinger ivan-ottinger self-assigned this Nov 27, 2023
@ivan-ottinger ivan-ottinger added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Nov 27, 2023
@ivan-ottinger ivan-ottinger requested a review from a team November 27, 2023 15:15
TimBroddin
TimBroddin previously approved these changes Nov 28, 2023
Copy link
Contributor

@TimBroddin TimBroddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine!

@ivan-ottinger ivan-ottinger added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Nov 28, 2023
@phcp phcp requested a review from a team November 29, 2023 14:57
* Add RTL support

* Add changelog

* Fix position
Copy link
Contributor

@phcp phcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Code looks good and works as expected.

@phcp phcp removed the request for review from a team November 30, 2023 10:48
@phcp phcp added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 30, 2023
@ivan-ottinger ivan-ottinger merged commit 14fb296 into trunk Nov 30, 2023
@ivan-ottinger ivan-ottinger deleted the add/like-widget-dialog-new-desgin branch November 30, 2023 11:05
@github-actions github-actions bot added this to the jetpack/12.9 milestone Nov 30, 2023
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Likes [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improving likes: implement new dialog design

5 participants