Skip to content

Conversation

@manzoorwanijk
Copy link
Member

Right now the quick share is enabled for scheduled posts which should not be the case.

Proposed changes:

  • Disable Quick Share for Scheduled posts

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Create a post
  • Schedule it
  • On post publish sidebar, confirm that quick share panel is not displayed.

@manzoorwanijk manzoorwanijk added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Nov 29, 2023
@manzoorwanijk manzoorwanijk requested a review from a team November 29, 2023 08:59
@manzoorwanijk manzoorwanijk self-assigned this Nov 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/disable-quick-share-for-sched-posts branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/disable-quick-share-for-sched-posts
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@manzoorwanijk manzoorwanijk enabled auto-merge (squash) November 29, 2023 09:36
@manzoorwanijk manzoorwanijk merged commit 12b00ad into trunk Nov 29, 2023
@manzoorwanijk manzoorwanijk deleted the update/disable-quick-share-for-sched-posts branch November 29, 2023 09:43
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants