Skip to content

Conversation

@pyronaur
Copy link
Contributor

Proposed changes:

Refactor the interface of DataSync so that mutation and query functions are always created immediately and you don't need to follow them up with another call.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

🌈

@pyronaur pyronaur requested a review from thingalon November 29, 2023 09:57
@github-actions github-actions bot added [JS Package] React Data Sync Client [Plugin] Boost A feature to speed up the site and improve performance. RNA labels Nov 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: January 2, 2024.
  • Scheduled code freeze: December 25, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 29, 2023
thingalon
thingalon previously approved these changes Nov 29, 2023
Copy link
Member

@thingalon thingalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I <3 this

@pyronaur pyronaur enabled auto-merge (squash) December 2, 2023 08:35
@haqadn haqadn added [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 5, 2023
Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pyronaur pyronaur merged commit 4eb6a42 into trunk Dec 5, 2023
@pyronaur pyronaur deleted the boost-react/datasync-more-like-react branch December 5, 2023 11:11
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[JS Package] React Data Sync Client [Plugin] Boost A feature to speed up the site and improve performance. RNA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants