Skip to content

Conversation

@edanzer
Copy link
Contributor

@edanzer edanzer commented Dec 1, 2023

Proposed changes:

  • Updates the destination link for the Set up an offer for your supporters task on the Monetize > Launchpad. Ensures that the link immediately opens to modal to add a plan by appending an existing hash to the url.
  • For now, we are just opening the general product modal. We may want to consider customizing this so that if a site has newsletter site intent, we open the modal but with a newsletter tier pre-loaded.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. You will need a test site that has Stripe connected, but does not have a paid plan.
  2. Load this branch in your sandbox using the bin command below. Sandbox public api and the domain of your test site.
  3. Open the Monetize screen by going to http://calypso.localhost:3000/earn/YOURSITESLUG
  4. You should see the Launchpad at the top of the page. Click the link to Set up an offer for your supporters. Confirm that it takes you to the payment page and immediately opens the modal to create a plan.

@edanzer edanzer added Earn Earn features [Plugin] mu wpcom jetpack-mu-wpcom plugin [mu wpcom Feature] Launchpad labels Dec 1, 2023
@edanzer edanzer requested a review from a team December 1, 2023 01:05
@edanzer edanzer self-assigned this Dec 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/earn-launchpad-open-plan-modal branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/earn-launchpad-open-plan-modal
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Package] Jetpack mu wpcom WordPress.com Features label Dec 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Mu Wpcom plugin:

  • Next scheduled release: January 2, 2024.
  • Scheduled code freeze: December 25, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 1, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only real change in this PR. Everything else is version/changelog related, and is generated automatically from the fixup-versions script.

@edanzer edanzer changed the title Update/earn launchpad open plan modal Launchpad: Update link for paid offer task Dec 1, 2023
@simison simison added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 1, 2023
simison
simison previously approved these changes Dec 1, 2023
@simison simison force-pushed the update/earn-launchpad-open-plan-modal branch from 580de40 to d950b8c Compare December 1, 2023 09:47
@simison simison enabled auto-merge (squash) December 1, 2023 09:48
@simison simison merged commit 58a8518 into trunk Dec 1, 2023
@simison simison deleted the update/earn-launchpad-open-plan-modal branch December 1, 2023 09:50
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Earn Earn features [mu wpcom Feature] Launchpad [Package] Jetpack mu wpcom WordPress.com Features [Plugin] mu wpcom jetpack-mu-wpcom plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants