Skip to content

Conversation

@simison
Copy link
Member

@simison simison commented Apr 16, 2025

Some minor optimizations to use componentry instead of CSS in some parts of the integrations modal.

Only visual change should be the button size.

Before

Screenshot 2025-04-16 at 17 44 26

After

Screenshot 2025-04-16 at 22 20 57

Proposed changes:

  • Use HStack instead of CSS+div
  • Remove un-used is-spinning CSS + animation
  • Set margin-bottom to 0 in toggle component instead of using CSS
  • Opt-in button CTA to slightly larger button sizes with __next40pxDefaultSize@ilonagl smaller button looked a bit more balanced and I'm not sure which ones we use in Figma library, but the larger ones are sort of the future version in Gutenberg componentry. We can at this point use either smaller or bigger.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@simison simison requested review from edanzer and ilonagl April 16, 2025 19:26
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 16, 2025
@simison simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 16, 2025
@simison simison force-pushed the update/forms-integrations-modal-cleanup branch from 6eb0ea3 to 8e26e5f Compare April 16, 2025 19:29
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-integrations-modal-cleanup branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-integrations-modal-cleanup

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link

jp-launch-control bot commented Apr 16, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison simison force-pushed the update/forms-integrations-modal-cleanup branch from 8e26e5f to 9ae11c2 Compare April 24, 2025 07:43
@simison
Copy link
Member Author

simison commented Apr 24, 2025

We'll need to improve mobile screen for this, but this PR doesn't make it worse either and is identical with Trunk:

Screenshot 2025-04-24 at 11 00 48

@simison simison merged commit 45db7c7 into trunk Apr 24, 2025
65 checks passed
@simison simison deleted the update/forms-integrations-modal-cleanup branch April 24, 2025 08:08
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants