-
Notifications
You must be signed in to change notification settings - Fork 843
Forms: use componentry instead of CSS in integrations modal #43117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
6eb0ea3 to
8e26e5f
Compare
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
8e26e5f to
9ae11c2
Compare

Some minor optimizations to use componentry instead of CSS in some parts of the integrations modal.
Only visual change should be the button size.
Before
After
Proposed changes:
HStackinstead of CSS+divis-spinningCSS + animation__next40pxDefaultSize— @ilonagl smaller button looked a bit more balanced and I'm not sure which ones we use in Figma library, but the larger ones are sort of the future version in Gutenberg componentry. We can at this point use either smaller or bigger.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: