Skip to content

Conversation

@coder-karen
Copy link
Contributor

@coder-karen coder-karen commented Apr 21, 2025

Fixes https://github.com/Automattic/vulcan/issues/679
Fixes VULCAN-62

Proposed changes:

  • This PR removes the geo-location.php from the module files that Jetpack requires.
  • It also removes all remaining geo-location code.
  • Even though we are removing the file being required and the require at the same time, if we split this up we will en up with more warnings and notices than will be faced with any mid-deploy issues (see the comment here: Geo Location: Remove remaining module related files #43162 (comment))

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

The Geo Location feature was already not in use any more (by Jetpack and also related theme compat files), so to test, ensure you don't see any error logs related to Geo Location on any Jetpack-connected test site (including WoA and Simple (using the command in the generated comment below to test the changes on a sandboxed Simple site).

For self-hosted and WoA sites, you can also visit the Jetpack modules page at wp-admin/admin.php?page=jetpack_modules and you should notice that the Geo Location module is no longer listed there.

@coder-karen coder-karen added [Type] Janitorial [Feature] Geo Location [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Apr 21, 2025
@coder-karen coder-karen self-assigned this Apr 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the remove/geo-location-includes branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack remove/geo-location-includes

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: May 6, 2025
    • Code freeze: May 5, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 21, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Apr 21, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/modules/module-extras.php 4/34 (11.76%) 0.34% -1 💚
projects/plugins/jetpack/modules/module-headings.php 206/1000 (20.60%) 0.05% -18 💚

Full summary · PHP report · JS report

@coder-karen coder-karen removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 21, 2025
@coder-karen coder-karen marked this pull request as ready for review April 21, 2025 10:41
@coder-karen coder-karen requested a review from a team April 21, 2025 10:41
@coder-karen coder-karen added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 21, 2025
@fgiannar fgiannar self-requested a review April 24, 2025 08:59
Copy link
Contributor

@fgiannar fgiannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@fgiannar fgiannar added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 24, 2025
@coder-karen coder-karen merged commit 5661c62 into trunk Apr 24, 2025
70 checks passed
@coder-karen coder-karen deleted the remove/geo-location-includes branch April 24, 2025 09:24
@github-actions github-actions bot added this to the jetpack/14.6 milestone Apr 24, 2025
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Geo Location [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants