-
Notifications
You must be signed in to change notification settings - Fork 843
Geo Location: Remove geo-location from module files being required #43159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
|
fgiannar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Fixes https://github.com/Automattic/vulcan/issues/679
Fixes VULCAN-62
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
The Geo Location feature was already not in use any more (by Jetpack and also related theme compat files), so to test, ensure you don't see any error logs related to Geo Location on any Jetpack-connected test site (including WoA and Simple (using the command in the generated comment below to test the changes on a sandboxed Simple site).
For self-hosted and WoA sites, you can also visit the Jetpack modules page at
wp-admin/admin.php?page=jetpack_modulesand you should notice that the Geo Location module is no longer listed there.