Skip to content

Conversation

@coder-karen
Copy link
Contributor

@coder-karen coder-karen commented Apr 21, 2025

Fixes #42051

Proposed changes:

  • This PR adds a sentence below the Featured Content section description (in the Customize) to clarify that the tag name must be case sensitive.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

Testing instructions:

To test on a self-hosted site, apply this PR locally (or using the Jetpack Beta tester plugin - as with a WoA test site). For Simple - apply the PR by using the command in the generated comment below for a sandboxed Simple site.

  • Install and activate a theme that uses Featured Content such as Dara.
  • Open up the Customizer, and open up the Featured Content section.
  • You should see a new sentence explaining that the tag name is case sensitive.

@coder-karen coder-karen added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] Classic Theme Helper labels Apr 21, 2025
@coder-karen coder-karen self-assigned this Apr 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: May 6, 2025
    • Code freeze: May 5, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Classic Theme helper plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/featured-content-tag-case-message branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/featured-content-tag-case-message
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/featured-content-tag-case-message

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link

jp-launch-control bot commented Apr 21, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/classic-theme-helper/src/class-featured-content.php 0/285 (0.00%) 0.00% 8 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@coder-karen coder-karen marked this pull request as ready for review April 21, 2025 14:15
@coder-karen coder-karen added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 21, 2025
@coder-karen coder-karen requested a review from a team April 21, 2025 14:18
jeherve
jeherve previously approved these changes Apr 21, 2025
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Given that the description is within a div, I was wondering if it may be better to use a br to denote the line break instead of a p, but I don't think that really matters that much :)

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 21, 2025
@coder-karen
Copy link
Contributor Author

I was wondering if it may be better to use a br to denote the line break instead of ap

Thanks for the review! Happy to change it - I like the additional line as it highlights the message a little more, so added two line breaks to give the appearance of a new paragraph.

@coder-karen coder-karen added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Apr 22, 2025
@coder-karen coder-karen merged commit df3121d into trunk Apr 22, 2025
69 checks passed
@coder-karen coder-karen deleted the add/featured-content-tag-case-message branch April 22, 2025 09:57
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Theme Tools I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Package] Classic Theme Helper [Plugin] Classic Theme Helper Plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Featured Content: Add a message to inform users that the featured content tags are case sensitive

3 participants