Launchpad - update add_subscribe_block task completion and calypso url

[Addison-Stavlo]

Fixes # Automattic/loop#649

Proposed changes:

Updates the add_subscribe_block task to

• Also be considered complete if one of the site options enabling it on the front end are enabled.
• Direct users to the newsletter settings to enable the above noted options, as this is easier than the previous method where users had to add the block in the site editor.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Patch this to dotcom, sandbox the public api
• Go to users->subscribers in calypso on a new site with the launchpad checklist available
• click the task to add the subscribe block
• verify it goes to the newsletter settings
• enable one of the newsletter settings that mentions the "subscribe block" (there are two).
• navigate back to the launchpad and verify the task is marked as complete.
• test by enabling this branch on an atomic site as well.
  • note for atomic - the site needs to be in 'default' view setting. Also In the jetpack beta tester plugin I had to apply this branch to wpcomsh in addition to wordpress.com features.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the update/launchpad_add_subscribe_block_task branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/launchpad_add_subscribe_block_task

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad-task-definitions.php	642/1506 (42.63%)	-0.09%	3 ❤️‍🩹

Full summary · PHP report

[allilevine]

I tested on Simple and Atomic and I was able to complete the task by enabling a subscribe block option in newsletter settings:

On Atomic, I was redirected to Jetpack Newsletter settings regardless of whether I was in Default or Classic. But enabling a block setting there completes the task too.

[Addison-Stavlo]

On Atomic, I was redirected to Jetpack Newsletter settings regardless of whether I was in Default or Classic

That makes sense and is what I found for this page as well. Were you able to find this checklist at all on Classic? I seemed to have to turn it to "Default" to go find the checklist.

[allilevine]

On Atomic, I was redirected to Jetpack Newsletter settings regardless of whether I was in Default or Classic

That makes sense and is what I found for this page as well. Were you able to find this checklist at all on Classic? I seemed to have to turn it to "Default" to go find the checklist.

Yes! It moves to Jetpack > Subscribers.