-
Notifications
You must be signed in to change notification settings - Fork 843
Boost: Gracefully handle overflow of max concat files #43176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 3 files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is working (for CSS at least).
I've added the filter with 3 max files, but the page is broken.
Here's the source of concatenated files:
I added elementor and a couple of blocks to make it output a lot of stylesheets. Just to make sure my tests are okay, I switched to trunk and everything works.
…jetpack into fix/concat-max-file-overflow
dilirity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! CSS now works as well. Let's merge this!
![]()
Co-authored-by: Peter Petrov <peter.petrov89@gmail.com>

Fixes HOG-17
Fixes #40365
Proposed changes:
jetpack_boost_minify_concat_max_filesOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: