Skip to content

My Jetpack: Onboarding i3 - Feature Branch/PR#43592

Merged
robertsreberski merged 28 commits intotrunkfrom
feature/my-jetpack/onboarding-i3
Jun 2, 2025
Merged

My Jetpack: Onboarding i3 - Feature Branch/PR#43592
robertsreberski merged 28 commits intotrunkfrom
feature/my-jetpack/onboarding-i3

Conversation

@manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented May 23, 2025

This serves as the base/feature branch for the My Jetpack onboarding i3 changes - p1HpG7-wJV-p2

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@manzoorwanijk manzoorwanijk added [Status] In Progress [Type] Feature Development of a new feature labels May 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the feature/my-jetpack/onboarding-i3 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack feature/my-jetpack/onboarding-i3
bin/jetpack-downloader test jetpack-mu-wpcom-plugin feature/my-jetpack/onboarding-i3

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented May 23, 2025

Code Coverage Summary

Coverage changed in 8 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/packages/my-jetpack/_inc/hooks/use-connect-site/index.ts 0/23 (0.00%) -56.52% 13 💔
projects/packages/my-jetpack/_inc/data/products/use-products-by-ownership.ts 0/11 (0.00%) -81.82% 9 💔
projects/packages/my-jetpack/_inc/context/value-store/valueStoreContext.tsx 5/13 (38.46%) -53.85% 7 💔
projects/packages/my-jetpack/_inc/components/my-jetpack-screen/index.jsx 0/45 (0.00%) 0.00% 3 ❤️‍🩹
projects/packages/my-jetpack/_inc/context/notices/noticeTemplates.ts 0/2 (0.00%) -100.00% 2 ❤️‍🩹

23 files are newly checked for coverage. Only the first 5 are listed here.

File Coverage
projects/packages/my-jetpack/_inc/components/a4a-banner/index.jsx 0/12 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/help-card/index.tsx 0/1 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/icons/code.tsx 0/1 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/icons/comment.tsx 0/1 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/icons/tool.tsx 0/1 (0.00%) 💔

Full summary · PHP report · JS report

Coverage check overridden by Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code .

@manzoorwanijk manzoorwanijk changed the title My Jetpack: Onboarding i3 - Base Branch/PR My Jetpack: Onboarding i3 - Feature Branch/PR May 26, 2025
manzoorwanijk and others added 13 commits May 26, 2025 19:06
* My Jetpack: Onboarding i3 - Init tab panel

* Improve types and use constants and extractions

* Add changelog to make CI happy

* Create a shared tab content wrapper to share styling

* Use "section" instead of tabs

* Rename tab components to content components

* Use correct headings

* Decrease margins on smaller screens

* Fix initial tab changed manually
* My Jetpack: Onboarding i3 | Split the overview tab

* Fix separator position
* My Jetpack: Onboarding i3 | Update help section

* Remove double parenthesis

* Thank you copilot
* Moving unowned products to the Products tab

* Products tab header and spacing update

* Moving owned and unowned products into a hook

* changelog

* Update projects/packages/my-jetpack/_inc/components/product-cards-section/style.module.scss

RTL aware alternative

Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>

* Update projects/packages/my-jetpack/_inc/components/product-cards-section/style.module.scss

RTL aware alternative

Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>

---------

Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
* My Jetpack: Tab fitering for admin role

* changelog

* replacing permission check
…iew tab (#43681)

* My Jetpack: Onboarding i3 | Move Plan and Connection section to Overview tab

* Remove unused styles

* Fix unit tests

* Fix E2E tests

* Add changelog

* Fix top border for the plan and connection section

* Fix E2E test heading

* Update E2E test string

* Update connection owner message when author is not connected

* Fix typo in changelog, thanks to copilot review.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix connection block for JN sites

* Move Jetpack Manage upsell banner to Overview

* Update banner messaging

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests E2E Tests labels May 30, 2025
@grbicsanja
Copy link

Looking good! 🙌

On the products tab, let's change the copy to:

Manage and explore Jetpack products that boost growth, performance, and security.

@grbicsanja
Copy link

While testing, something strange happened - a settings icon appeared next to the filter icon (initially it wasn't there, it appeared after I interacted with the page, used the filters and activated a product). This is what it looks like:
Screenshot 2025-05-30 at 14 47 03

@manzoorwanijk manzoorwanijk self-assigned this Jun 2, 2025
@manzoorwanijk manzoorwanijk requested a review from a team June 2, 2025 05:53
@manzoorwanijk manzoorwanijk marked this pull request as ready for review June 2, 2025 05:53
@manzoorwanijk manzoorwanijk added [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] In Progress labels Jun 2, 2025
@manzoorwanijk manzoorwanijk added the Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code label Jun 2, 2025
@manzoorwanijk
Copy link
Member Author

While testing, something strange happened - a settings icon appeared next to the filter icon (initially it wasn't there, it appeared after I interacted with the page, used the filters and activated a product).

Fixed via #43722

@manzoorwanijk
Copy link
Member Author

On the products tab, let's change the copy to:

Manage and explore Jetpack products that boost growth, performance, and security.

Completed via #43724

robertsreberski and others added 2 commits June 2, 2025 13:15
* Add jetpack_myjetpack_tab_click, jetpack_myjetpack_page_view (enhance), jetpack_myjetpack_help_request events

* Merge and resolve conflict in my-jetpack-tab-panel/index.tsx

Combined functionality from both branches:
- Analytics tracking and session duration from HEAD
- Product filtering logic from feature/my-jetpack/onboarding-i3
- Maintained all imports and hooks from both versions
- Preserved the analytics event tracking while adding dynamic tab visibility

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Improve source tab definition on help tracking hook

---------

Co-authored-by: Claude <noreply@anthropic.com>
* Fix horizontal scrollable space

* Fix Jetpack log and tabs aligment issues

* Add changelog

* OK Copilot
Copy link
Contributor

@robertsreberski robertsreberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go :shipit:

@robertsreberski robertsreberski merged commit 7e1133e into trunk Jun 2, 2025
84 checks passed
@robertsreberski robertsreberski deleted the feature/my-jetpack/onboarding-i3 branch June 2, 2025 13:00
@github-actions github-actions bot removed [Status] In Progress [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Jun 2, 2025
mikestottuk pushed a commit that referenced this pull request Jun 26, 2025
* Init

* My Jetpack: Onboarding i3 - Initialize tab panel (#43595)

* My Jetpack: Onboarding i3 - Init tab panel

* Improve types and use constants and extractions

* Add changelog to make CI happy

* Create a shared tab content wrapper to share styling

* Use "section" instead of tabs

* Rename tab components to content components

* Use correct headings

* Decrease margins on smaller screens

* Fix initial tab changed manually

* My Jetpack: Onboarding i3 | Split the overview tab (#43632)

* My Jetpack: Onboarding i3 | Split the overview tab

* Fix separator position

* My Jetpack: Onboarding i3 | Add help section (#43638)

* My Jetpack: Onboarding i3 | Update help section

* Remove double parenthesis

* Thank you copilot

* My Jetpack: Updating Products tab. (#43652)

* Moving unowned products to the Products tab

* Products tab header and spacing update

* Moving owned and unowned products into a hook

* changelog

* Update projects/packages/my-jetpack/_inc/components/product-cards-section/style.module.scss

RTL aware alternative

Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>

* Update projects/packages/my-jetpack/_inc/components/product-cards-section/style.module.scss

RTL aware alternative

Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>

---------

Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>

* My Jetpack: Tab filtering for admin role (#43675)

* My Jetpack: Tab fitering for admin role

* changelog

* replacing permission check

* My Jetpack: Onboarding i3 | Move Plan and Connection section to Overview tab (#43681)

* My Jetpack: Onboarding i3 | Move Plan and Connection section to Overview tab

* Remove unused styles

* Fix unit tests

* Fix E2E tests

* Add changelog

* Fix top border for the plan and connection section

* Fix E2E test heading

* Update E2E test string

* Update connection owner message when author is not connected

* Fix typo in changelog, thanks to copilot review.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix connection block for JN sites

* Move Jetpack Manage upsell banner to Overview

* Update banner messaging

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* My Jetpack: Onboarding i3 | Fix layout on wider screens (#43699)

* My Jetpack: Update upsell banner for Automattic for Agencies (#43697)

* Update Jetpack Manage banner to A4A

* Fix Help section CTA styling

* Remove redundant changelogs

* Updating Products tab visibility based on owned products (#43720)

* Remove repeated changelog

* My Jetpack: Onboarding i3 | Update Products tab description copy (#43724)

* Add tracks events for My Jetpack Tab Navigation (#43703)

* Add jetpack_myjetpack_tab_click, jetpack_myjetpack_page_view (enhance), jetpack_myjetpack_help_request events

* Merge and resolve conflict in my-jetpack-tab-panel/index.tsx

Combined functionality from both branches:
- Analytics tracking and session duration from HEAD
- Product filtering logic from feature/my-jetpack/onboarding-i3
- Maintained all imports and hooks from both versions
- Preserved the analytics event tracking while adding dynamic tab visibility

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Improve source tab definition on help tracking hook

---------

Co-authored-by: Claude <noreply@anthropic.com>

* My jetpack: Onboarding i3 | Fix layout and alignment issues (#43725)

* Fix horizontal scrollable space

* Fix Jetpack log and tabs aligment issues

* Add changelog

* OK Copilot

* My Jetpack: Replace deprecated sass APIs with alternatives (#43726)

---------

Co-authored-by: Grzegorz Chudzinski-Pawlowski <112354940+grzegorz-cp@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Robert Sreberski <robertsreberski@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code E2E Tests [JS Package] Components [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA [Tests] Includes Tests [Type] Feature Development of a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants