Conversation
- Added new properties for legend label and container styles in ChartTheme. - Updated BaseLegend component to utilize theme styles for legend labels and container. - Refactored BarChart and LineChart components to remove dependency on providerTheme for legend shape styles. - Cleaned up unused imports and styles in related components.
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
bot
added
the
[Status] Needs Author Reply
Code Coverage SummaryCoverage changed in 2 files.
|
chihsuan
commented
Jun 10, 2025
| color: group.options?.stroke || theme.colors[ index % theme.colors.length ], | ||
| shapeStyle: | ||
| group?.options?.legendShapeStyle ?? providerTheme.legendShapeStyles?.[ index ] ?? {}, | ||
| shapeStyle: group?.options?.legendShapeStyle, |
Member
Author
There was a problem hiding this comment.
Remove providerTheme.legendShapeStyle logic from bar/line chart since BaseLegend now handles all theme-related styling internally.
chihsuan
added
Enhancement
kangzj
approved these changes
Jun 10, 2025
Contributor
kangzj
left a comment
kangzj
left a comment
There was a problem hiding this comment.
Looks good to me!
I'm thinking of something similar as well - to move these colors, patterns and shapes control to the themes, and to make the themes easier to customize 👍
chihsuan
deleted the
charts-31-add-supports-for-customizing-legend-labelcontainer-styles
branch
github-actions
bot
removed
the
[Status] Needs Review
mikestottuk
pushed a commit
that referenced
this pull request
Jun 26, 2025
* Enhance chart legend styling and theme integration - Added new properties for legend label and container styles in ChartTheme. - Updated BaseLegend component to utilize theme styles for legend labels and container. - Refactored BarChart and LineChart components to remove dependency on providerTheme for legend shape styles. - Cleaned up unused imports and styles in related components. * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Enable customization of legend labels and container styles via the theme provider.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
pnpm --filter="@automattic/charts" storybook