Skip to content

Comments

super-cache: Fix E2E tests#43886

Merged
anomiex merged 2 commits intotrunkfrom
fix/super-cache-e2e-test
Jun 12, 2025
Merged

super-cache: Fix E2E tests#43886
anomiex merged 2 commits intotrunkfrom
fix/super-cache-e2e-test

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Jun 10, 2025

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try running the tests.

* Update MariaDB image health check for v11 images.
* Update container ID detection for docker-compose v2.
* Pass `Accept: text/html` in requests for #29456. (Axios by default
  passes `application/json, text/plain, */*`).
@anomiex anomiex requested review from a team June 10, 2025 17:22
@anomiex anomiex self-assigned this Jun 10, 2025
@anomiex anomiex added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Normal labels Jun 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Super Cache plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@anomiex
Copy link
Contributor Author

anomiex commented Jun 10, 2025

I ran into these failing when testing for whether #43808 would break the tests if we pnpmfile-hack the dependency instead of waiting for kulshekhar/ts-jest#4891 or keeping jest v29 here.

@jp-launch-control
Copy link

jp-launch-control bot commented Jun 10, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In trunk I couldn't env:up, probably related:

 ✔ wordpress                              Built                            0.0s 
 ✔ Network super-cache-e2e_default        Created                          0.0s 
 ✔ Volume "super-cache-e2e_db_data"       Created                          0.0s 
 ✔ Volume "super-cache-e2e_wp_data"       Created                          0.0s 
 ✘ Container super-cache-e2e-db-1         Error                          101.2s 
 ✔ Container super-cache-e2e-wordpress-1  Created                          0.0s 
dependency failed to start: container super-cache-e2e-db-1 is unhealthy
 ELIFECYCLE  Command failed with exit code 1.

This branch spins up the image and runs the tests successfully.

I am curious why this didn't come up before. The last run I see related to super-cache skipped the E2E tests altogether (is this something we want):
https://github.com/Automattic/jetpack/actions/runs/15542181460/job/43755327828

@anomiex
Copy link
Contributor Author

anomiex commented Jun 10, 2025

In trunk I couldn't env:up, probably related:

Yeah, the "Update MariaDB image health check for v11 images" is needed to fix that. The Docker MariaDB image stopped including mysqladmin, it only has mariadb-admin now.

I am curious why this didn't come up before. The last run I see related to super-cache skipped the E2E tests altogether

As far as I can tell, no one ever got around to adding these into CI. They're intentionally not using the tools/e2e-commons stuff, and maybe even aren't really "E2E" tests in the sense of our other E2Es.

@anomiex anomiex merged commit 750b059 into trunk Jun 12, 2025
63 checks passed
@anomiex anomiex deleted the fix/super-cache-e2e-test branch June 12, 2025 16:46
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jun 12, 2025
@github-actions github-actions bot added this to the super-cache/1.12.5 milestone Jun 12, 2025
mikestottuk pushed a commit that referenced this pull request Jun 26, 2025
* Update MariaDB image health check for v11 images.
* Update container ID detection for docker-compose v2.
* Pass `Accept: text/html` in requests for #29456. (Axios by default
  passes `application/json, text/plain, */*`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended E2E Tests [Plugin] Super Cache A fast caching plugin for WordPress. [Pri] Normal [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants