Conversation
* Update MariaDB image health check for v11 images. * Update container ID detection for docker-compose v2. * Pass `Accept: text/html` in requests for #29456. (Axios by default passes `application/json, text/plain, */*`).
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Super Cache plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
I ran into these failing when testing for whether #43808 would break the tests if we pnpmfile-hack the dependency instead of waiting for kulshekhar/ts-jest#4891 or keeping jest v29 here. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
There was a problem hiding this comment.
In trunk I couldn't env:up, probably related:
✔ wordpress Built 0.0s
✔ Network super-cache-e2e_default Created 0.0s
✔ Volume "super-cache-e2e_db_data" Created 0.0s
✔ Volume "super-cache-e2e_wp_data" Created 0.0s
✘ Container super-cache-e2e-db-1 Error 101.2s
✔ Container super-cache-e2e-wordpress-1 Created 0.0s
dependency failed to start: container super-cache-e2e-db-1 is unhealthy
ELIFECYCLE Command failed with exit code 1.
This branch spins up the image and runs the tests successfully.
I am curious why this didn't come up before. The last run I see related to super-cache skipped the E2E tests altogether (is this something we want):
https://github.com/Automattic/jetpack/actions/runs/15542181460/job/43755327828
Yeah, the "Update MariaDB image health check for v11 images" is needed to fix that. The Docker MariaDB image stopped including
As far as I can tell, no one ever got around to adding these into CI. They're intentionally not using the |
* Update MariaDB image health check for v11 images. * Update container ID detection for docker-compose v2. * Pass `Accept: text/html` in requests for #29456. (Axios by default passes `application/json, text/plain, */*`).
Proposed changes:
Accept: text/htmlin requests for WP Super Cache - add support for the Accept HTTP header #29456. (Axios by default passesapplication/json, text/plain, */*).Other information:
Jetpack product discussion
None.
Does this pull request change what data or activity we track or use?
No
Testing instructions: