Skip to content

Comments

Prevent PHP warning when checking for deprecated blocks#43889

Merged
tbradsha merged 2 commits intotrunkfrom
fix/jetpack/php_warning_in_Jetpack_Gutenberg
Jun 11, 2025
Merged

Prevent PHP warning when checking for deprecated blocks#43889
tbradsha merged 2 commits intotrunkfrom
fix/jetpack/php_warning_in_Jetpack_Gutenberg

Conversation

@tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Jun 10, 2025

Similar to #43865, we get about 160K of these per month on WP Cloud:

PHP Warning: Undefined array key "blockName" in /wordpress/plugins/jetpack/14.8-a.3/class.jetpack-gutenberg.php on line 1289

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

🤷

@tbradsha tbradsha requested review from a team and jeherve June 10, 2025 19:27
@tbradsha tbradsha self-assigned this Jun 10, 2025
@tbradsha tbradsha added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. Bug labels Jun 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/jetpack/php_warning_in_Jetpack_Gutenberg branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/jetpack/php_warning_in_Jetpack_Gutenberg

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jun 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: July 1, 2025
    • Code freeze: June 30, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Haven't tested.

@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@tbradsha tbradsha requested a review from anomiex June 10, 2025 19:55
@tbradsha
Copy link
Contributor Author

Looks reasonable. Haven't tested.

Thanks; I just noticed two more that were quite similar and updated this PR.

@tbradsha tbradsha requested a review from a team June 10, 2025 20:30
@anomiex
Copy link
Contributor

anomiex commented Jun 10, 2025

Thanks; I just noticed two more that were quite similar and updated this PR.

I think you accidentally updated #43890 with those instead of this PR. 😀

@tbradsha
Copy link
Contributor Author

Blast. I'll just leave it and let people review things as they lie. 😅

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then my previous review on this PR still stands. 😀

@tbradsha tbradsha merged commit 3f87691 into trunk Jun 11, 2025
75 checks passed
@tbradsha tbradsha deleted the fix/jetpack/php_warning_in_Jetpack_Gutenberg branch June 11, 2025 12:42
@github-actions github-actions bot added this to the jetpack/14.8 milestone Jun 11, 2025
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jun 11, 2025
mikestottuk pushed a commit that referenced this pull request Jun 26, 2025
* Prevent PHP warning in Jetpack_Gutenberg

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants