Prevent PHP warning when checking for deprecated blocks#43889
Prevent PHP warning when checking for deprecated blocks#43889
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
anomiex
left a comment
There was a problem hiding this comment.
Looks reasonable. Haven't tested.
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Thanks; I just noticed two more that were quite similar and updated this PR. |
I think you accidentally updated #43890 with those instead of this PR. 😀 |
|
Blast. I'll just leave it and let people review things as they lie. 😅 |
anomiex
left a comment
There was a problem hiding this comment.
Then my previous review on this PR still stands. 😀
* Prevent PHP warning in Jetpack_Gutenberg * Add changelog
Similar to #43865, we get about 160K of these per month on WP Cloud:
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
🤷