Skip to content

Comments

Launchpad: Updated task_id plan_selected order to be the first one#43945

Merged
paulopmt1 merged 2 commits intotrunkfrom
update/plan-selected-order-step-from-build-task
Jun 13, 2025
Merged

Launchpad: Updated task_id plan_selected order to be the first one#43945
paulopmt1 merged 2 commits intotrunkfrom
update/plan-selected-order-step-from-build-task

Conversation

@paulopmt1
Copy link
Contributor

Fixes https://linear.app/a8c/issue/DOTCOM-13604/launchpad-dont-change-the-items-order-after-completion

Proposed changes:

  • Since we're not reordering tasks anymore as part of this Calypso change, we want the Plan selected to be the first one

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

@paulopmt1 paulopmt1 requested a review from a team June 13, 2025 02:46
@paulopmt1 paulopmt1 added [Status] Needs Review This PR is ready for review. Task labels Jun 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the update/plan-selected-order-step-from-build-task branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/plan-selected-order-step-from-build-task

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

jp-launch-control bot commented Jun 13, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

m1r0
m1r0 previously approved these changes Jun 13, 2025
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulopmt1 paulopmt1 merged commit 6ded5f0 into trunk Jun 13, 2025
64 checks passed
@paulopmt1 paulopmt1 deleted the update/plan-selected-order-step-from-build-task branch June 13, 2025 14:28
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jun 13, 2025
mikestottuk pushed a commit that referenced this pull request Jun 26, 2025
…43945)

* Launchpad: Updated task_id plan_selected order to be the first one

* Updated Enable subscribers modal item order as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants