-
Notifications
You must be signed in to change notification settings - Fork 842
Jetpack Forms: fix notched label focus #43956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
dhasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* elevate notched labels for outline styles so they receive the first focus * changelog * prevent Enter key on notched labels
Part of FORMS-148
Fixes FORMS-148
Proposed changes:
This PR elevates outline styled notched labels so they are more easily selectable. The main bug remains (hitting enter on a notched label) but this already helps the user deal with labels that are empty.
Other information:
Jetpack product discussion
FORMS-148
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Create a form and add some text input. Select the form and make it style Outline.
On a text input, see that you can now delete the contents of the label (it'll show "Add label...") and as per style the label will be at the same position as the input. Click on "Add label..." to verify the focus remains on the label and not on the input.