Skip to content

Subscriptions: add minified build for legacy widget css #44546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 3 commits into from
Jul 31, 2025
Merged

Subscriptions: add minified build for legacy widget css #44546

jeherve merged 3 commits into from
Jul 31, 2025

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Jul 30, 2025 •
edited
Loading

Fixes CML-733
See #44532

Proposed changes:

  • Add new file to the existing CSS config, so the stylesheet for the legacy Subscriptions widget can be minified.
  • Enqueue that minified CSS in production environments.
  • Also allow inlining that CSS.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start with a site connected to WordPress.com, where the Subscriptions module is active.
  • In your site's wp-config.php file, ensure that SCRIPT_DEBUG is set to false.
  • Install and activate the Twenty Ten theme.
  • Install and activate the Classic Widgets plugin.
  • Go to Appearance > Widgets
  • Add the Subscriptions widget to your site.
  • Go to the frontend of your site and check your network tab.
    • You should see a _inc/build/subscriptions/subscriptions.min.css file getting enqueued.
  • Now update wp-config.php to set SCRIPT_DEBUG to true.
  • Reload your home page.
    • You should see the existing modules/subscriptions/subscriptions.css site getting enqueued.

@jeherve jeherve self-assigned this Jul 30, 2025
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Focus] Performance [Status] In Progress Enhancement labels Jul 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/subscriptions-widget-support-inlining branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/subscriptions-widget-support-inlining

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: August 5, 2025
    • Code freeze: August 4, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Jul 30, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/modules/subscriptions/views.php 17/596 (2.85%) -0.02% 4 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@jeherve jeherve added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Jul 30, 2025
@jeherve jeherve mentioned this pull request Jul 30, 2025
Closed
@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 30, 2025
@jeherve jeherve requested a review from a team July 30, 2025 14:23
allilevine
allilevine approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and see the correct files being loaded with and without SCRIPT_DEBUG ✅

@jeherve jeherve merged commit 7d14577 into trunk Jul 31, 2025
69 checks passed
@jeherve jeherve deleted the update/subscriptions-widget-support-inlining branch July 31, 2025 15:13
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 31, 2025
@github-actions github-actions bot added this to the jetpack/14.9 milestone Jul 31, 2025
jeherve added a commit that referenced this pull request Jan 23, 2026
@jeherve
Likes: add minified build for CSS
e412964 
Add the likes module CSS to the webpack CSS config so it gets minified
for production. Update both likes.php and the Like block to use
Assets::get_file_url_for_environment to serve the minified version
when SCRIPT_DEBUG is false.

Follows the pattern established for subscriptions in #44546.
@jeherve jeherve mentioned this pull request Jan 23, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allilevine allilevine allilevine approved these changes

Assignees

@jeherve jeherve

Labels

Enhancement [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Focus] Performance I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

jetpack/14.9

Development

Successfully merging this pull request may close these issues.

3 participants

@jeherve @allilevine