Forms: use entire button area for selecting multi-select options#46263
Forms: use entire button area for selecting multi-select options#46263
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
93b7b71 to
2e7a1f3
Compare
1dd14de to
ceca284
Compare
ceca284 to
d954f1e
Compare
Resolves FORMS-131
Proposed changes:
While this introduces some semantic oddity (there's a "label" CSS class in
span, it achieves a functionally better experience without compromising backwards compatibility.An alternative would be reworking the CSS class structure and perhaps applying the tag change only to the button style.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: