Skip to content

Forms: use entire button area for selecting multi-select options#46263

Merged
CGastrell merged 7 commits intotrunkfrom
update/forms-multi-checkbox-button-label
Dec 11, 2025
Merged

Forms: use entire button area for selecting multi-select options#46263
CGastrell merged 7 commits intotrunkfrom
update/forms-multi-checkbox-button-label

Conversation

@simison
Copy link
Copy Markdown
Member

@simison simison commented Dec 11, 2025

Resolves FORMS-131

Proposed changes:

  • Makes entire button style checkbox clickable area, instead of just text+checkbox
Screenshot 2025-12-11 at 10 44 19

While this introduces some semantic oddity (there's a "label" CSS class in span, it achieves a functionally better experience without compromising backwards compatibility.

An alternative would be reworking the CSS class structure and perhaps applying the tag change only to the button style.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Add couple multi selection checkbox fields
  • Swhich to pill style
  • Try both fields still look good on editor and frontend
  • Try clicking them, try keyboard navigate them

@simison simison requested a review from a team December 11, 2025 09:11
@simison simison added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. labels Dec 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-multi-checkbox-button-label branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-multi-checkbox-button-label

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Feature] Forms [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Dec 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: January 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented Dec 11, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison simison force-pushed the update/forms-multi-checkbox-button-label branch from 93b7b71 to 2e7a1f3 Compare December 11, 2025 10:24
CGastrell
CGastrell previously approved these changes Dec 11, 2025
Copy link
Copy Markdown
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! :shipit:

@CGastrell CGastrell force-pushed the update/forms-multi-checkbox-button-label branch from 1dd14de to ceca284 Compare December 11, 2025 17:00
@CGastrell CGastrell force-pushed the update/forms-multi-checkbox-button-label branch from ceca284 to d954f1e Compare December 11, 2025 19:44
@CGastrell CGastrell merged commit 449a2b0 into trunk Dec 11, 2025
69 checks passed
@CGastrell CGastrell deleted the update/forms-multi-checkbox-button-label branch December 11, 2025 20:19
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Dec 11, 2025
@github-actions github-actions Bot added this to the jetpack/15.4 milestone Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Feature] Forms [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants