jetpack-mu-wpcom: Code block fixes and improvements #46418

sirreal · 2025-12-29T16:23:16Z

Proposed changes:

A list of popular languages are sorted at the top of the language dropdown (closes ARC-1306):

Before	After

Ensure that the "show language name" option displays "Plain text" language name when selected (fixes ARC-1305):

Before	After
(no language displayed)

Replace show filename toggle with filename input field (closes ARC-1307):

Before	After

Improve line highlight color based on text color (closes ARC-1308):

Before	After

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pdtkmj-42c-p2#comment-8195
pdtkmj-42c-p2#comment-8230

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Test out the modified functionality in the Code block and confirm it works as expected.

github-actions · 2025-12-29T16:24:28Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the code-block/fixes-polish branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin code-block/fixes-polish

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-12-29T16:24:30Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2025-12-29T16:27:53Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/class-code-block.php	0/310 (0.00%)	0.00%	2 ❤️‍🩹

Full summary · PHP report

Copilot

Pull request overview

This PR enhances the code block functionality with several UX improvements and fixes, including reorganizing the language dropdown to prioritize popular languages, ensuring "Plain text" displays correctly as a language name, replacing the filename toggle with a direct input field, and improving the active line highlight color using relative color syntax.

Sorted popular languages at the top of the language dropdown for easier access
Fixed display of "Plain text" language name when showLanguageName is enabled
Replaced filename toggle with direct filename input field in settings panel

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/editor.css`	Adds new active line highlight using oklch relative color syntax
`projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/common/block.ts`	Removes deprecated showFileName attribute from interface
`projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/class-code-block.php`	Removes showFileName attribute registration and updates rendering logic to always show filename when present, adds "Plain text" fallback for language display
`projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/block-definition/block-definition.tsx`	Adds popular languages section to dropdown, replaces filename toggle with TextControl input, updates language display logic, and adds copy button click handler
`projects/packages/jetpack-mu-wpcom/changelog/code-block-fixes-polish`	Documents the changes as a minor addition

...ckages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/block-definition/block-definition.tsx

projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/class-code-block.php

projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/editor.css

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/editor.css

...ckages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/block-definition/block-definition.tsx

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/block-definition/block-definition.tsx:216

The toolbar dropdown menu should also display popular languages at the top, similar to the SelectControl in the sidebar. Currently, it only shows "Plain text" followed by all languages in alphabetical order, but doesn't include the popular languages section that was added to the sidebar dropdown.

									{ selectLanguageOptions.map( option => (
										<MenuItem
											key={ option.value }
											role="menuitemradio"
											isSelected={ option.value === props.attributes.language }
											onClick={ () => {
												props.setAttributes( {
													language: option.value,
													languageConfidence: 'certain',
												} );
												onClose();
											} }
										>
											{ option.label }
										</MenuItem>
									) ) }

cbravobernal

LGTM

ARC-1307

ARC-1305

Replaces the default static current line highlight with a highlight color based on a reduced-opacity current text color. ARC-1308

ARC-1306

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Copilot · 2026-01-05T12:23:04Z

...ckages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/block-definition/block-definition.tsx

+					</SelectControl>
+					<TextControl
+						label={ __( 'Filename', 'jetpack-mu-wpcom' ) }
+						defaultValue={ attributes.filename }


Using defaultValue instead of value for a controlled input means the component won't update when attributes.filename changes externally. This can lead to the displayed value being out of sync with the actual attribute value. Consider using value prop instead to make this a properly controlled component.

Suggested change

defaultValue={ attributes.filename }

value={ attributes.filename }

Copilot · 2026-01-05T12:23:05Z

...ckages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/block-definition/block-definition.tsx

+										isSelected={ emptyLanguageOption.value === props.attributes.language }
+										onClick={ () => {
+											props.setAttributes( {
+												language: emptyLanguageOption.value,
+												languageConfidence: 'certain',
+											} );


The comparison emptyLanguageOption.value === props.attributes.language may not work correctly if props.attributes.language is undefined or null instead of an empty string. Consider using a more robust check like !props.attributes.language or explicitly checking for undefined/null values.

Suggested change

isSelected={ emptyLanguageOption.value === props.attributes.language }

onClick={ () => {

props.setAttributes( {

language: emptyLanguageOption.value,

languageConfidence: 'certain',

} );

isSelected={ ! props.attributes.language }

onClick={ () => {

props.setAttributes( {

language: emptyLanguageOption.value,

languageConfidence: 'certain',

} );

sirreal added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress labels Dec 29, 2025

github-actions bot added [mu wpcom Feature] Wpcom Blocks [Package] Jetpack mu wpcom WordPress.com Features labels Dec 29, 2025

sirreal force-pushed the code-block/fixes-polish branch 2 times, most recently from e6ebf3e to 0201616 Compare January 2, 2026 16:16

sirreal marked this pull request as ready for review January 2, 2026 16:51

Copilot AI review requested due to automatic review settings January 2, 2026 16:51

sirreal added [Status] Needs Review This PR is ready for review. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. and removed [Status] In Progress labels Jan 2, 2026

sirreal requested a review from a team January 2, 2026 16:51

Copilot started reviewing on behalf of sirreal January 2, 2026 16:51 View session

github-actions bot added the [Status] In Progress label Jan 2, 2026

Copilot AI reviewed Jan 2, 2026

View reviewed changes

sirreal removed the [Status] In Progress label Jan 2, 2026

Copilot AI review requested due to automatic review settings January 2, 2026 17:19

Copilot started reviewing on behalf of sirreal January 2, 2026 17:20 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

projects/packages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/editor.css Show resolved Hide resolved

...ckages/jetpack-mu-wpcom/src/features/wpcom-blocks/code/block-definition/block-definition.tsx Show resolved Hide resolved

sirreal force-pushed the code-block/fixes-polish branch from 2bc8833 to 2d6fc0f Compare January 2, 2026 17:23

Copilot AI review requested due to automatic review settings January 2, 2026 17:36

Copilot started reviewing on behalf of sirreal January 2, 2026 17:37 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

cbravobernal previously approved these changes Jan 5, 2026

View reviewed changes

sirreal added 3 commits January 5, 2026 12:26

changelog

72be193

Add click handler to editor to copy text

e505bb2

Replace filename toggle with text field

cc8043e

ARC-1307

sirreal added 6 commits January 5, 2026 12:26

Ensure show language name displays plain text lang

8284360

ARC-1305

Use text-color based current line highlight

92c53bf

Replaces the default static current line highlight with a highlight color based on a reduced-opacity current text color. ARC-1308

Move some popular languages to the top of select

3cc63a7

ARC-1306

Remove duplicate plaintext language

f7705d4

Include null coalesce safety

2e8155a

Remove reudnant non-null assertion

5dc97d3

sirreal force-pushed the code-block/fixes-polish branch from 5c2d9b1 to 5dc97d3 Compare January 5, 2026 11:26

sirreal removed the [Status] Needs Review This PR is ready for review. label Jan 5, 2026

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 5, 2026

Use trimmed filename on change

dfe05c4

Copilot AI review requested due to automatic review settings January 5, 2026 12:19

sirreal dismissed cbravobernal’s stale review via dfe05c4 January 5, 2026 12:19

sirreal added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jan 5, 2026

Copilot started reviewing on behalf of sirreal January 5, 2026 12:19 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

sirreal merged commit 58f89c4 into trunk Jan 5, 2026
76 checks passed

sirreal deleted the code-block/fixes-polish branch January 5, 2026 12:46

github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 5, 2026

	defaultValue={ attributes.filename }
	value={ attributes.filename }

jetpack-mu-wpcom: Code block fixes and improvements #46418

jetpack-mu-wpcom: Code block fixes and improvements #46418

Conversation

sirreal commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

cbravobernal left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sirreal commented Dec 29, 2025 •

edited

Loading

github-actions bot commented Dec 29, 2025 •

edited

Loading

github-actions bot commented Dec 29, 2025 •

edited

Loading

jp-launch-control bot commented Dec 29, 2025 •

edited

Loading