Skip to content

Conversation

@dzver
Copy link
Member

@dzver dzver commented Jan 7, 2026

Reverts #46374

See the original PR for details. The wpcom PR caused an e2e failure.

Copilot AI review requested due to automatic review settings January 7, 2026 10:31
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the revert-46374-update/feature-gating-for-payments branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack revert-46374-update/feature-gating-for-payments

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Donations [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Wpcomsh [Type] Revert labels Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • 🔴 Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • 🔴 Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: Please edit your PR description and explain what functional changes your PR includes, and why those changes are needed.


🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts PR #46374, removing feature gating logic that was previously added for the Donations payment block. The revert restores the donations block to be available on all WordPress.com and Jetpack sites without sticker-based gating restrictions.

  • Removes complex sticker-based feature gating for donations and restores simple availability to all sites
  • Removes the plan_check parameter from donations block registration
  • Removes helper method and fallback logic for determining default plans for blocks

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
projects/plugins/wpcomsh/wpcom-features/class-wpcom-features.php Reverts DONATIONS feature configuration from sticker-based gating back to simple all-sites availability
projects/plugins/wpcomsh/changelog/update-feature-gating-for-payments Removes changelog entry for the feature being reverted
projects/plugins/jetpack/extensions/blocks/donations/donations.php Removes plan_check parameter from block registration
projects/plugins/jetpack/class.jetpack-gutenberg.php Removes get_default_plan_for_block() method and default plan fallback logic in set_availability_for_plan()
projects/plugins/jetpack/changelog/update-feature-gating-for-payments Removes changelog entry for the feature being reverted

@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/blocks/donations/donations.php 0/178 (0.00%) 0.00% -1 💚
projects/plugins/jetpack/class.jetpack-gutenberg.php 168/460 (36.52%) 0.70% -9 💚

Full summary · PHP report · JS report

@dzver dzver added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. labels Jan 7, 2026
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 7, 2026
Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts the mentioned change

@dzver dzver merged commit fd8d40b into trunk Jan 7, 2026
82 checks passed
@dzver dzver deleted the revert-46374-update/feature-gating-for-payments branch January 7, 2026 10:47
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Donations [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Wpcomsh [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Revert

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants