-
Notifications
You must be signed in to change notification settings - Fork 842
Revert "Feature gating for Donations payment block" #46469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 5ab97e2.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: Please edit your PR description and explain what functional changes your PR includes, and why those changes are needed. 🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so: 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts PR #46374, removing feature gating logic that was previously added for the Donations payment block. The revert restores the donations block to be available on all WordPress.com and Jetpack sites without sticker-based gating restrictions.
- Removes complex sticker-based feature gating for donations and restores simple availability to all sites
- Removes the
plan_checkparameter from donations block registration - Removes helper method and fallback logic for determining default plans for blocks
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
projects/plugins/wpcomsh/wpcom-features/class-wpcom-features.php |
Reverts DONATIONS feature configuration from sticker-based gating back to simple all-sites availability |
projects/plugins/wpcomsh/changelog/update-feature-gating-for-payments |
Removes changelog entry for the feature being reverted |
projects/plugins/jetpack/extensions/blocks/donations/donations.php |
Removes plan_check parameter from block registration |
projects/plugins/jetpack/class.jetpack-gutenberg.php |
Removes get_default_plan_for_block() method and default plan fallback logic in set_availability_for_plan() |
projects/plugins/jetpack/changelog/update-feature-gating-for-payments |
Removes changelog entry for the feature being reverted |
Code Coverage SummaryCoverage changed in 2 files.
|
gmjuhasz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverts the mentioned change
Reverts #46374
See the original PR for details. The wpcom PR caused an e2e failure.