Skip to content

Site: Add is_garden to no_member_fields for server side rendering#47123

Open
arthur791004 wants to merge 2 commits intotrunkfrom
feat/site-add-is-garden-to-default-fields
Open

Site: Add is_garden to no_member_fields for server side rendering#47123
arthur791004 wants to merge 2 commits intotrunkfrom
feat/site-add-is-garden-to-default-fields

Conversation

@arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Feb 13, 2026

Related to WOOPRD-2282

Proposed changes:

  • Add is_garden to no_member_fields to we can get the property from the server side without auth.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Request both /rest/v1.1/sites/:site and /rest/v1.2/sites/:site
  • Ensure you can see is_garden from the response

Copilot AI review requested due to automatic review settings February 13, 2026 13:46
@arthur791004 arthur791004 self-assigned this Feb 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the feat/site-add-is-garden-to-default-fields branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack feat/site-add-is-garden-to-default-fields

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Feb 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: March 3, 2026
    • Code freeze: March 3, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 13, 2026
@arthur791004 arthur791004 added the [Status] Needs Review This PR is ready for review. label Feb 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for returning the is_garden flag from the public/unauthenticated site endpoint response, enabling server-side rendering consumers to access the field without authentication.

Changes:

  • Add is_garden to the no_member_fields allowlist for unauthenticated /sites/%s requests.
  • Add a Jetpack changelog entry documenting the enhancement.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-get-site-endpoint.php Expands the unauthenticated response field allowlist to include is_garden.
projects/plugins/jetpack/changelog/feat-site-add-is-garden-to-default-fields Documents the change in the Jetpack changelog system.

'is_wpcom_flex',
'is_a4a_client',
'is_a4a_dev_site',
'is_garden',
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding is_garden to no_member_fields changes the unauthenticated/public /sites/%s response surface. Since this endpoint has unit tests, please add/update a test to cover that the field is included (and populated) when the request has no user/blog auth, to prevent regressions.

Copilot uses AI. Check for mistakes.
@jp-launch-control
Copy link

jp-launch-control bot commented Feb 13, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@arthur791004 arthur791004 force-pushed the feat/site-add-is-garden-to-default-fields branch from b80058b to 1f671ad Compare February 13, 2026 13:58
@arthur791004 arthur791004 removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Review This PR is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant