Post Media: Add Shortcodes class for shortcode ID extraction by jeherve · Pull Request #47200 · Automattic/jetpack

jeherve · 2026-02-18T16:40:30Z

Note

This only adds the functions to the package, it doesn't replace their usage across the codebase. I'll do that in a follow-up PR.
That means we only need to check that the CI checks pass in this PR.

Proposed changes:

Add a new Shortcodes class to the post-media package that consolidates shortcode ID extraction logic currently scattered across the Jetpack plugin codebase.
The class provides static methods for extracting media identifiers from shortcode attributes for: YouTube, Vimeo, TED, VideoPress (wpvideo/videopress), Hulu, and Archive.org (including books).
Includes a sanitize_youtube_url() helper that normalizes YouTube URLs (youtu.be, /v/, /shorts/, encoded ampersands, playlists).

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

This PR adds new code that is not yet used anywhere — it only introduces the new class and tests. Testing if CI is happy should be enough.

github-actions · 2026-02-18T16:41:44Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2026-02-18T16:43:30Z

Code Coverage Summary

1 file is newly checked for coverage.

File	Coverage
projects/packages/post-media/src/class-shortcodes.php	59/60 (98.33%) 💚

Full summary · PHP report

Copilot

Pull request overview

This PR introduces a new Automattic\Jetpack\Shortcodes utility in the jetpack-post-media package to centralize extraction of media identifiers from shortcode attributes (e.g., YouTube, Vimeo, TED, VideoPress, HTML5 audio/video, Hulu, Archive.org), along with PHPUnit coverage and a changelog entry.

Changes:

Added Shortcodes class with static helper/extractor methods (including YouTube URL normalization).
Added PHPUnit tests covering supported shortcode formats and edge cases.
Added a post-media package changelog entry documenting the addition.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
projects/packages/post-media/src/class-shortcodes.php	Adds the new `Shortcodes` class with media ID extraction and YouTube URL normalization logic.
projects/packages/post-media/tests/php/Shortcodes_Test.php	Adds unit tests for the new extraction/normalization methods.
projects/packages/post-media/changelog/jeherve-shortcode-extractors	Records the new functionality in the package changelog.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

projects/packages/post-media/src/class-shortcodes.php

projects/packages/post-media/tests/php/Shortcodes_Test.php

projects/packages/post-media/src/class-shortcodes.php

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

projects/packages/post-media/src/class-shortcodes.php

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

projects/packages/post-media/src/class-shortcodes.php

projects/packages/post-media/tests/php/Shortcodes_Test.php

projects/packages/post-media/src/class-shortcodes.php

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

projects/packages/post-media/src/class-shortcodes.php

…ode attributes Consolidate scattered shortcode ID extraction functions into a single Shortcodes class in the post-media package. Methods cover YouTube, Vimeo, TED, VideoPress (wpvideo and videopress), HTML5 video, audio, Hulu, and Archive.org (including books). Includes comprehensive tests (69 test cases) ported from existing tests and new coverage for previously untested extraction logic.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

projects/packages/post-media/src/class-shortcodes.php

allilevine

CI passes and the extraction looks good ✅

projects/packages/post-media/src/class-shortcodes.php

Co-authored-by: Allison Levine <1689238+allilevine@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T14:40:16Z

projects/packages/post-media/src/class-shortcodes.php

+			 * https://vimeo.com/album/1234567/video/7654321
+			 * https://player.vimeo.com/video/18427511
+			 */
+			$pattern = '/(?:https?:\/\/)?vimeo\.com\/(?:groups\/[^\/]+\/videos\/|album\/\d+\/video\/|video\/|channels\/[^\/]+\/videos\/|[^\/]+\/)?([0-9]+)(?:[^\'\"0-9<]|$)/i';


The regex pattern does not match player.vimeo.com URLs, but based on the test case at line 197-200 of the test file and the documentation comment at lines 145, it should. The pattern should be updated to include an optional subdomain match before vimeo.com. Consider changing the pattern to include (?:[^.]+\.)? before vimeo\.com to match domains like player.vimeo.com.

Suggested change

$pattern = '/(?:https?:\/\/)?vimeo\.com\/(?:groups\/[^\/]+\/videos\/|album\/\d+\/video\/|video\/|channels\/[^\/]+\/videos\/|[^\/]+\/)?([0-9]+)(?:[^\'\"0-9<]|$)/i';

$pattern = '/(?:https?:\/\/)?(?:[^.]+\.)?vimeo\.com\/(?:groups\/[^\/]+\/videos\/|album\/\d+\/video\/|video\/|channels\/[^\/]+\/videos\/|[^\/]+\/)?([0-9]+)(?:[^\'\"0-9<]|$)/i';

Copilot · 2026-02-19T14:40:16Z

projects/packages/post-media/src/class-shortcodes.php

+		}
+
+		$url = trim( $url, ' "' );
+		$url = trim( $url );


There are two consecutive trim calls where the second one is redundant. Line 55 already trims spaces (among other characters), so the second trim on line 56 has no effect. Consider combining these into a single call: trim($url, ' "') which will trim both spaces and quotes.

Suggested change

$url = trim( $url );

Copilot AI review requested due to automatic review settings February 18, 2026 16:40

Copilot started reviewing on behalf of jeherve February 18, 2026 16:41 View session

github-actions bot added [Package] Post Media [Tests] Includes Tests labels Feb 18, 2026

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 18, 2026

Copilot AI reviewed Feb 18, 2026

View reviewed changes

jeherve added [Status] In Progress [Pri] Normal Code Quality and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 18, 2026

jeherve self-assigned this Feb 18, 2026

Copilot AI review requested due to automatic review settings February 18, 2026 16:58

Copilot started reviewing on behalf of jeherve February 18, 2026 16:59 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 18, 2026 17:17

Copilot started reviewing on behalf of jeherve February 18, 2026 17:18 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

projects/packages/post-media/src/class-shortcodes.php Show resolved Hide resolved

projects/packages/post-media/tests/php/Shortcodes_Test.php Show resolved Hide resolved

projects/packages/post-media/src/class-shortcodes.php Show resolved Hide resolved

Copilot AI review requested due to automatic review settings February 18, 2026 17:49

Copilot started reviewing on behalf of jeherve February 18, 2026 17:50 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

projects/packages/post-media/src/class-shortcodes.php Show resolved Hide resolved

jeherve force-pushed the jeherve/shortcode-extractors branch from 52422fe to 131a3f8 Compare February 18, 2026 18:01

Copilot AI review requested due to automatic review settings February 18, 2026 18:08

jeherve force-pushed the jeherve/shortcode-extractors branch from 131a3f8 to 03b8dbf Compare February 18, 2026 18:08

Copilot started reviewing on behalf of jeherve February 18, 2026 18:09 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

projects/packages/post-media/src/class-shortcodes.php Show resolved Hide resolved

jeherve requested a review from a team February 18, 2026 18:25

jeherve removed the [Status] In Progress label Feb 18, 2026

jeherve added the [Status] Needs Review This PR is ready for review. label Feb 18, 2026

allilevine previously approved these changes Feb 18, 2026

View reviewed changes

projects/packages/post-media/src/class-shortcodes.php Outdated Show resolved Hide resolved

Update projects/packages/post-media/src/class-shortcodes.php

405a01e

Co-authored-by: Allison Levine <1689238+allilevine@users.noreply.github.com>

jeherve dismissed allilevine’s stale review via 405a01e February 19, 2026 14:33

Copilot AI review requested due to automatic review settings February 19, 2026 14:33

Copilot started reviewing on behalf of jeherve February 19, 2026 14:34 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

jeherve merged commit bc3da94 into trunk Feb 19, 2026
74 checks passed

jeherve deleted the jeherve/shortcode-extractors branch February 19, 2026 15:38

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Feb 19, 2026

jeherve mentioned this pull request Feb 20, 2026

Post Media: move Meta_Extractor class to jetpack-post-media package #47205

Open

3 tasks

	$pattern = '/(?:https?:\/\/)?vimeo\.com\/(?:groups\/[^\/]+\/videos\/\|album\/\d+\/video\/\|video\/\|channels\/[^\/]+\/videos\/\|[^\/]+\/)?([0-9]+)(?:[^\'\"0-9<]\|$)/i';
	$pattern = '/(?:https?:\/\/)?(?:[^.]+\.)?vimeo\.com\/(?:groups\/[^\/]+\/videos\/\|album\/\d+\/video\/\|video\/\|channels\/[^\/]+\/videos\/\|[^\/]+\/)?([0-9]+)(?:[^\'\"0-9<]\|$)/i';

Conversation

jeherve commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

allilevine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jeherve commented Feb 18, 2026 •

edited

Loading

github-actions bot commented Feb 18, 2026 •

edited

Loading

jp-launch-control bot commented Feb 18, 2026 •

edited

Loading