Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
463b4ac to
1e909ad
Compare
There was a problem hiding this comment.
Pull request overview
This PR configures Yjs dependency management to ensure a single instance is used across the application, preventing conflicts with shared document types. The change addresses the known Yjs issue where multiple instances break shared document functionality.
Changes:
- Added
@wordpress/sync,yjs,lib0, andy-protocolsas dependencies - Configured webpack externals to map both
@wordpress/syncandyjsto WordPress globals - Converted gutenberg-rtc entry point from
.jsto.ts
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/packages/jetpack-mu-wpcom/webpack.config.js | Added webpack externals configuration to resolve @wordpress/sync and yjs to WordPress globals, updated entry point file extension |
| projects/packages/jetpack-mu-wpcom/package.json | Added @wordpress/sync, yjs, lib0, and y-protocols package dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Changelog