Forms: Add form name modal to wp-build dashboard by enejb · Pull Request #47395 · Automattic/jetpack

enejb · 2026-02-28T00:08:05Z

Screen.Recording.2026-02-27.at.4.35.22.PM.mov

Proposed changes

When clicking "Create a form" on the wp-build forms dashboard, a modal now prompts the user to name their form before navigating to the editor
Added showNameModal prop to CreateFormButton (defaults to false) so the modal only appears in wp-build contexts
The useCreateForm hook now accepts an optional formTitle parameter, passed to the editor via post_title URL parameter
The editor's FormTitleModal checks for the post_title URL parameter and skips showing the duplicate naming modal when the user already named the form from the dashboard
Updated mobile dropdown menu entries in usePageHeaderDetails to also use the form name modal

Other information

All changes are scoped to projects/packages/forms. The modal reuses the existing FormNameModal component.

Does this pull request change what data or activity we track or use?

No

Testing instructions

Enable jetpack_forms_alpha and central form management
Go to the Forms dashboard (wp-build route)
Click "Create a form" — a modal should appear asking for the form name
Enter a name and click "Create" — you should be navigated to the form editor with the title set
Verify the editor's own naming modal does not appear (since you already named the form)
Go back to dashboard, click "Create a form" again, and click "Cancel" — modal should close without navigating
Click "Create a form" and click "Create" without entering a name — the editor should open and show its own naming modal
On mobile, use the dropdown menu's "Create a form" option — same modal behavior
Disable jetpack_forms_alpha / central form management and verify the old dashboard's "Create a form" button still works without showing a modal

When creating a new form from the wp-build forms dashboard, show a modal prompting the user to name their form before navigating to the editor. The form title is passed via URL parameter, and the editor's own naming modal is skipped when a title was already provided from the dashboard. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-02-28T00:09:05Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/form-wp-build-create-form branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/form-wp-build-create-form

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-02-28T00:09:06Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copilot

Pull request overview

Adds a “name your form” modal to the wp-build Forms dashboard create flow, passing the chosen name into the editor so the editor-side naming modal can be skipped when appropriate.

Changes:

Introduces showNameModal on CreateFormButton (default off) to optionally prompt for a name before creating a form.
Extends useCreateForm.openNewForm to accept formTitle and forwards it to wp-admin via post_title query param.
Updates the editor’s FormTitleModal to skip prompting when post_title is present, and wires the same naming modal into the mobile actions dropdown.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
projects/packages/forms/src/form-editor/plugins/form-title-modal.tsx	Skips editor naming modal when `post_title` is present in the URL.
projects/packages/forms/src/dashboard/wp-build/hooks/use-page-header-details.tsx	Adds mobile “Create a form” modal flow + enables modal for wp-build header buttons.
projects/packages/forms/src/dashboard/hooks/use-create-form.ts	Adds optional `formTitle` to build a `post_title` URL param.
projects/packages/forms/src/dashboard/components/create-form-button/index.tsx	Adds optional naming modal gating the create-form button.
projects/packages/forms/routes/forms/stage.tsx	Enables `showNameModal` for the wp-build “empty state” create button.
projects/packages/forms/changelog/update-form-wp-build-create-form	Changelog entry for the new modal behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-28T00:13:00Z

projects/packages/forms/src/dashboard/components/create-form-button/index.tsx

+	const handleModalSave = useCallback(
+		async ( formName: string ) => {
+			await openNewForm( {
 				showPatterns,
+				formTitle: formName,
 				analyticsEvent: () => {
 					jetpackAnalytics.tracks.recordEvent( 'jetpack_wpa_forms_landing_page_cta_click', {
 						button: 'forms',
 					} );
 				},
-			} ),
+			} );
+		},


FormNameModal always passes a non-empty name to onSave (it falls back to "Untitled Form" when the input is empty). That means formTitle will always be truthy here, so useCreateForm will always append post_title=..., and the editor’s FormTitleModal will always skip showing—contradicting the intended behavior where submitting an empty name should allow the editor naming modal to appear. Consider updating the flow so an empty input results in no post_title param (e.g., add an option to FormNameModal to allow empty/undefined results, or pass through an empty string and only include post_title when the user actually entered a name).

No we do want this to be the case otherwise we show the modal twice.

projects/packages/forms/src/dashboard/wp-build/hooks/use-page-header-details.tsx

projects/packages/forms/src/form-editor/plugins/form-title-modal.tsx

Copilot · 2026-02-28T00:13:00Z

projects/packages/forms/src/form-editor/plugins/form-title-modal.tsx

+		const hasPostTitle = urlParams.has( 'post_title' );
+
+		if ( isFormEditor && ! hasInnerBlocks && isNewForm && ! hasShown && ! hasPostTitle ) {


urlParams.has('post_title') treats post_title as present even if it’s empty (e.g. ?post_title=), and it will also skip the modal even when the value is just the default/placeholder. To avoid suppressing the editor naming modal unintentionally, consider using urlParams.get('post_title') and only skipping when the value is non-empty/meaningful.

Suggested change

const hasPostTitle = urlParams.has( 'post_title' );

if ( isFormEditor && ! hasInnerBlocks && isNewForm && ! hasShown && ! hasPostTitle ) {

const postTitle = urlParams.get( 'post_title' );

const hasMeaningfulPostTitle =

typeof postTitle === 'string' && postTitle.trim() !== '';

if (

isFormEditor &&

! hasInnerBlocks &&

isNewForm &&

! hasShown &&

! hasMeaningfulPostTitle

) {

projects/packages/forms/src/dashboard/hooks/use-create-form.ts

jp-launch-control · 2026-02-28T00:20:19Z

Code Coverage Summary

Coverage changed in 4 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/dashboard/components/create-form-button/index.tsx	0/14 (0.00%)	0.00%	9 💔
projects/packages/forms/src/dashboard/wp-build/hooks/use-page-header-details.tsx	0/109 (0.00%)	0.00%	7 💔
projects/packages/forms/src/dashboard/hooks/use-create-form.ts	0/40 (0.00%)	0.00%	3 ❤️‍🩹
projects/packages/forms/src/form-editor/plugins/form-title-modal.tsx	42/43 (97.67%)	0.24%	0 💚

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-28T00:46:20Z

projects/packages/forms/src/dashboard/wp-build/hooks/use-page-header-details.tsx

+		async ( formName: string ) => {
+			const trimmedName = formName.trim();
+			if ( trimmedName ) {
+				await openNewForm( { formTitle: trimmedName } );
+			} else {
+				await openNewForm( {} );
+			}


handleCreateFormSave has an else branch intended to create a form without a title (so post_title is omitted), but FormNameModal always calls onSave with a non-empty fallback (trimmed input || "Untitled Form"). As a result trimmedName will always be truthy here and the else branch is effectively dead, and the editor’s FormTitleModal will always be skipped.

If you want the “Create with empty name -> show editor naming modal” behavior, FormNameModal needs an option to allow empty/undefined results (or a separate “Skip naming” action). Otherwise, simplify this handler and update the documented/testing expectations accordingly.

Copilot AI review requested due to automatic review settings February 28, 2026 00:08

enejb added the [Status] Needs Review This PR is ready for review. label Feb 28, 2026

Copilot started reviewing on behalf of enejb February 28, 2026 00:08 View session

github-actions bot added [Feature] Contact Form [Package] Forms labels Feb 28, 2026

github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Feb 28, 2026

Copilot AI reviewed Feb 28, 2026

View reviewed changes

enejb added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 28, 2026

Apply suggestions from code review

a609dca

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 28, 2026 00:40

Copilot started reviewing on behalf of enejb February 28, 2026 00:41 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forms: Add form name modal to wp-build dashboard#47395

Forms: Add form name modal to wp-build dashboard#47395
enejb wants to merge 2 commits intotrunkfrom
update/form-wp-build-create-form

enejb commented Feb 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 28, 2026

Uh oh!

enejb Feb 28, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 28, 2026

Uh oh!

Uh oh!

jp-launch-control bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const hasPostTitle = urlParams.has( 'post_title' );

		if ( isFormEditor && ! hasInnerBlocks && isNewForm && ! hasShown && ! hasPostTitle ) {

Conversation

enejb commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Other information

Does this pull request change what data or activity we track or use?

Testing instructions

Uh oh!

github-actions bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

enejb Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jp-launch-control bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

enejb commented Feb 28, 2026 •

edited

Loading

github-actions bot commented Feb 28, 2026 •

edited

Loading

github-actions bot commented Feb 28, 2026 •

edited

Loading

jp-launch-control bot commented Feb 28, 2026 •

edited

Loading