Social: Get rid of the UNIFIED_UI_V1 feature flag uses#47759
Social: Get rid of the UNIFIED_UI_V1 feature flag uses#47759manzoorwanijk wants to merge 8 commits intotrunkfrom
Conversation
…ault The unified UI has been in place long enough to remove the feature flag. This keeps the enabled code paths and removes the legacy fallbacks.
Remove components that are no longer imported after making the unified UI the default: EnhancedFeaturesNudge, SocialPostModal, MediaSection (old), SocialImageGeneratorPanel, ShareStatusModal, ShareList, and usePostCanUseSig.
…odals Remove share post modal and share status modal store logic that is no longer used: toggleSharePostModal, openSharePostModal, closeSharePostModal, isSharePostModalOpen, openShareStatusModal, closeShareStatusModal, toggleShareStatusModal, isShareStatusModalOpen, and related constants/types.
Remove PreviewSection, SettingsSection, ScheduledShares components and their associated style files that were only used by the deleted modal.
Move post-preview.tsx from the now-empty social-post-modal directory to customize-and-preview/preview-section where it is imported.
These were only used by the deleted SocialImageGeneratorPanel component.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 10 files. Only the first 5 are listed here.
1 file is newly checked for coverage.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
Completes SOCIAL-415
Proposed changes
Remove the
UNIFIED_UI_V1feature flag from the publicize package and make the unified UI the default. Since the UI changes have been in place for a while, the feature flag is no longer needed.siteHasFeature( features.UNIFIED_UI_V1 )checks, keeping the enabled (truthy) code pathsUNIFIED_UI_V1constant fromconstants.tsEnhancedFeaturesNudge,SocialPostModal,MediaSection(old),SocialImageGeneratorPanel(panel/),ShareStatusModal,ShareList,GeneratedImagePreviewusePostCanUseSig,useSaveImageToLibraryopenSharePostModal,closeSharePostModal,toggleSharePostModal,openShareStatusModal,closeShareStatusModal,toggleShareStatusModal), selectors (isSharePostModalOpen,isShareStatusModalOpen), reducer cases, constants, and related typessocial-post-modal/directory and movePostPreviewto its only consumer (customize-and-preview/preview-section/)The
SOCIAL_UNIFIED_UI_V1constant in wpcomsh is intentionally kept to support older plugin versions.43 files changed, -2,153 lines net
Other information
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions