Skip to content

Remove RTC is enabled check before registering the notices endpoint#47774

Merged
rcrdortiz merged 2 commits intotrunkfrom
dotcom-16486-validate-that-the-modals-work-on-simple-sites-remove-check
Mar 25, 2026
Merged

Remove RTC is enabled check before registering the notices endpoint#47774
rcrdortiz merged 2 commits intotrunkfrom
dotcom-16486-validate-that-the-modals-work-on-simple-sites-remove-check

Conversation

@rcrdortiz
Copy link
Contributor

@rcrdortiz rcrdortiz commented Mar 25, 2026

Fixes:

Proposed changes

  • Remove the RTC enabled check so that the endpoint can be registered on Simple sites.

Other information

  • Generate changelog entries for this PR (using AI).

Related product discussion/links

  • No

Does this pull request change what data or activity we track or use?

Testing instructions

  • Apply to your sandbox.
  • Make sure you have Gutenberg edge and wpcom feature stickers.
  • Go to the editor with RTC enabled.
  • Dismissing the welcome notice should work as expected.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the dotcom-16486-validate-that-the-modals-work-on-simple-sites-remove-check branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotcom-16486-validate-that-the-modals-work-on-simple-sites-remove-check

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 25, 2026
@jp-launch-control
Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/gutenberg-rtc-notices/gutenberg-rtc-notices.php 52/67 (77.61%) 2.25% -2 💚

Full summary · PHP report

@rcrdortiz rcrdortiz merged commit f84fed3 into trunk Mar 25, 2026
71 checks passed
@rcrdortiz rcrdortiz deleted the dotcom-16486-validate-that-the-modals-work-on-simple-sites-remove-check branch March 25, 2026 16:03
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant