Add nonce protection to Social admin plan refresh#47844
Conversation
Agent-Logs-Url: https://github.com/Automattic/jetpack/sessions/529daf3a-170a-4530-9581-d51fd3aca058 Co-authored-by: manzoorwanijk <18226415+manzoorwanijk@users.noreply.github.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so: 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 3 files.
Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
manzoorwanijk
left a comment
There was a problem hiding this comment.
@copilot Let us make CI happy
Agent-Logs-Url: https://github.com/Automattic/jetpack/sessions/40363902-fbae-4b76-931a-cb65c48f3194 Co-authored-by: manzoorwanijk <18226415+manzoorwanijk@users.noreply.github.com>
Re-ran package PHP tests after installing the test env; they now pass (composer test-php) with 72a0686. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/Automattic/jetpack/sessions/971c2bb6-dc75-4eb2-8c10-8b7ab634cd4b Co-authored-by: manzoorwanijk <18226415+manzoorwanijk@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/Automattic/jetpack/sessions/6cbe5dac-ae33-4492-8966-73cf410f4337 Co-authored-by: manzoorwanijk <18226415+manzoorwanijk@users.noreply.github.com>
Fixed the PHPCS warnings by adding safe wp_json_encode flags and aligning the assignments; package PHP tests now pass locally (composer test-php) in ad5d3af. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
| * @return callable | ||
| */ | ||
| public function throw_on_wp_die() { | ||
| return static function ( $message ) { |
There was a problem hiding this comment.
@copilot To fix the static analysis, you need to add a PHPDoc block to the closure here.
There was a problem hiding this comment.
Added a PHPDoc block to the wp_die assertion closure to satisfy static analysis; package PHP tests pass (composer test-php) in 0343cec.
Agent-Logs-Url: https://github.com/Automattic/jetpack/sessions/222fbdbf-8e3a-48b8-9504-f82d517ffeae Co-authored-by: manzoorwanijk <18226415+manzoorwanijk@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Original prompt