Complete shared-extension-utils externalization to prevent duplicate store registration by kraftbj · Pull Request #47850 · Automattic/jetpack

kraftbj · 2026-03-30T20:41:47Z

Proposed changes

Finish the externalization of @automattic/jetpack-shared-extension-utils by dropping the external: false opt-out for /store/wordpress-com and re-exporting wordpressPlansStore from the package root
Migrate Jetpack's runtime consumers to the root import so the shared package resolves once through the WP dependency
Remove the select() duplicate-registration guards (and their tests); the fix is now packaging behavior rather than local checks
Keep the shared UMD bundle in packages/assets, but enqueue its extracted CSS when the shared script handle is already enqueued
Switch the bundle's textdomain to jetpack-assets and add a babel override so bundled strings hit the existing assets-package translation infrastructure
Keep the minimal jetpackConfig shim for the shared UMD build
Update changelog entries to match the final scope; drop the connection changelog since that change reverted

Known follow-up: if Store "jetpack-connection" is already registered reappears on My Jetpack after backing out the connection-package guard, that's a separate architectural issue (jetpack-connection is in defaultRequestMap but not actually built as a UMD) and will be handled in its own PR.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Run composer test-php in projects/packages/assets.
Run jp test js js-packages/shared-extension-utils.
Run jp build packages/assets and confirm jetpack-shared-extension-utils.js and .css emit.
Run jp build plugins/jetpack --deps.
Confirm a Jetpack block editor .asset.php includes jetpack-shared-extension-utils as a dependency.
Open the Jetpack block editor and confirm no duplicate-registration warnings for jetpack-modules or wordpress-com/plans.
Confirm .has-warning.is-interactive block editor styles apply (validates the CSS enqueue hook).

The `jetpack-modules` and `wordpress-com/plans` stores were being registered multiple times because shared-extension-utils was bundled independently into every consumer's webpack output. This adds the package to the webpack externals map and builds a single UMD bundle via the assets package, following the same pattern used for jetpack-script-data and jetpack-connection. Also adds try/catch guards around store registration calls as defense-in-depth against future regressions.

github-actions · 2026-03-30T20:42:43Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the investigate-jetpack-1437 branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack investigate-jetpack-1437

bin/jetpack-downloader test jetpack-mu-wpcom-plugin investigate-jetpack-1437

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-03-30T20:42:56Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: May 5, 2026
- Code freeze: May 4, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

The I18nCheckPlugin auto-detects textdomain from the host package's composer.json (jetpack-assets), but the bundled shared-extension-utils code uses its own textdomain. Override I18nCheckPlugin and I18nLoaderPlugin to expect jetpack-shared-extension-utils.

Add phpcs:ignore for TextDomainMismatch and I18nTextDomainFixer since the bundled code uses its own textdomain, not the host package's.

jp-launch-control · 2026-03-30T21:18:14Z

Code Coverage Summary

2 files are newly checked for coverage.

File	Coverage
projects/packages/assets/src/class-shared-extension-utils-assets.php	6/15 (40.00%) ❤️‍🩹
projects/packages/assets/src/js/shared-extension-utils.js	0/0 (—%) 🤷

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

…1437 # Conflicts: # projects/packages/assets/package.json

…1437

Copilot

Pull request overview

Externalizes @automattic/jetpack-shared-extension-utils to a shared WP script dependency to prevent duplicate bundling that can trigger duplicate Redux store registration errors in the block editor.

Changes:

Add @automattic/jetpack-shared-extension-utils to the webpack dependency-extraction request map and document the behavior.
Build a jetpack-shared-extension-utils UMD bundle in packages/assets and register it in PHP for use as a WordPress script dependency.
Add store registration guards and update related tests and test setup (including removing now-unneeded console error suppression).

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
projects/plugins/jetpack/tools/check-block-assets.php	Updates the block view-script dependency allowlist.
projects/plugins/jetpack/changelog/externalize-shared-extension-utils	Changelog entry for the Jetpack plugin allowlist update.
projects/packages/paypal-payments/tests/jest.setup.js	Removes suppression of the “already registered” console error in tests.
projects/packages/paypal-payments/changelog/fix-duplicate-store-registration	Changelog entry for PayPal Payments test setup change.
projects/packages/assets/webpack.config.js	Adds a new build target to output the shared-extension-utils UMD bundle.
projects/packages/assets/src/js/shared-extension-utils.js	Entry module re-exporting `@automattic/jetpack-shared-extension-utils` for bundling.
projects/packages/assets/src/class-shared-extension-utils-assets.php	Registers the new `jetpack-shared-extension-utils` script handle in PHP.
projects/packages/assets/actions.php	Hooks the new asset registration into WordPress load.
projects/packages/assets/package.json	Adds the JS dependency and build tooling needed for the new bundle.
projects/packages/assets/changelog/externalize-shared-extension-utils	Changelog entry for adding the new UMD bundle/registration.
projects/js-packages/webpack-config/src/webpack.js	Externalizes the root shared-extension-utils package and exempts selected subpaths.
projects/js-packages/webpack-config/README.md	Documents the new extracted dependency and the subpath exception behavior.
projects/js-packages/webpack-config/changelog/externalize-shared-extension-utils	Changelog entry for webpack-config externals update.
projects/js-packages/shared-extension-utils/src/store/wordpress-com/index.ts	Adds a guard to prevent duplicate store registration.
projects/js-packages/shared-extension-utils/src/store/wordpress-com/test/store-registration.test.js	Adds tests for the wordpress-com store registration guard.
projects/js-packages/shared-extension-utils/src/modules-state/index.js	Adds a guard to prevent duplicate modules store registration.
projects/js-packages/shared-extension-utils/src/modules-state/test/store-registration.test.js	Adds tests for modules-state store registration guard and initial data population.
projects/js-packages/shared-extension-utils/src/hooks/use-module-status/test/index.test.js	Extends mocks to accommodate updated modules-state registration logic.
projects/js-packages/shared-extension-utils/changelog/fix-duplicate-store-registration	Changelog entry for the shared-extension-utils guard.
projects/js-packages/connection/state/store-holder.jsx	Adds a guard to prevent duplicate connection store registration.
projects/js-packages/connection/changelog/investigate-jetpack-1437	Changelog entry for connection store registration guard.
pnpm-lock.yaml	Lockfile updates for new/updated workspace dependencies.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

anomiex

Subpath imports (/components, /icons, /site-type-utils, /store/wordpress-com) are explicitly excluded from externalization and continue to be bundled. Note: /store/wordpress-com has store registration side effects at module scope; the others are side-effect free.

I'm skeptical about this part. If we're going to externalize the package, we should probably fully do so instead of allowing subpath imports to bypass it. Especially we shouldn't allow a subpath import of the store that's the reason we're doing this in the first place.

It's possible this means that just the store bit should be its own package, which a non-externalized shared-extension-utils could re-export for back compat. Or (if it's possible) that we should externalize only that one subpath import (and make the stores available only via that subpath import, not via the barrel import).

…1437 # Conflicts: # projects/packages/assets/package.json

kraftbj · 2026-04-17T21:23:25Z

Reworked in 30741fc based on the feedback in this review round.

The earlier version was doing two things at once — partial externalization plus duplicate-registration guards — and the guards were really compensating for the partial part. Backed out the guards and finished the externalization:

/store/wordpress-com is no longer specially bundled
shared-extension-utils re-exports wordpressPlansStore from the root
Jetpack runtime consumers import from the root, so the shared package resolves through the WP dependency once

On the assets side:

Dropped the css_path => null workaround; the shared bundle now enqueues its extracted CSS when the script handle is in use (with a PHP test covering the hook)
Switched the bundle's textdomain to jetpack-assets and added a babel override so bundled strings land in the existing assets-package translation infrastructure

Validation:

composer test-php in projects/packages/assets
jp test js js-packages/shared-extension-utils
jp build packages/assets
jp build plugins/jetpack --deps

Known follow-up: if Store "jetpack-connection" is already registered still shows up on My Jetpack after removing the connection-package guard, I'll handle that separately. jetpack-connection is in the defaultRequestMap but isn't actually built as a UMD, which is a separate architectural issue from this PR.

github-actions bot added [JS Package] Shared Extension Utils [JS Package] Webpack Config [Package] Assets [Package] Paypal Payments [Status] In Progress [Tests] Includes Tests Docs RNA labels Mar 30, 2026

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 30, 2026

kraftbj removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 30, 2026

kraftbj added 5 commits March 30, 2026 15:47

Fix textdomain in PHP registration for shared-extension-utils

ccb2b07

Add phpcs:ignore for TextDomainMismatch and I18nTextDomainFixer since the bundled code uses its own textdomain, not the host package's.

chore: add changelog entries for shared-extension-utils externalization

16f6571

fix: remove unneeded wp-plugins from story block allowlist

a754ee0

chore: add changelog for jetpack plugin

25e9549

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 30, 2026

kraftbj added 5 commits March 30, 2026 16:47

fix: use truthiness check for store registration guards

df870c0

fix: add missing select/dispatch mocks to useModuleStatus test

a293c16

test: add store registration guard tests

93757b8

fix: use main entry point for jetpack-connection import

e4d8be1

fix: resolve console errors in shared-extension-utils UMD bundle

8516a70

github-actions bot added the [JS Package] Connection label Mar 31, 2026

kraftbj added 2 commits March 31, 2026 21:52

chore: add changelog for connection store registration guard fix

211d341

Merge remote-tracking branch 'origin/trunk' into investigate-jetpack-…

b308900

…1437 # Conflicts: # projects/packages/assets/package.json

kraftbj added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Apr 16, 2026

Merge remote-tracking branch 'origin/trunk' into investigate-jetpack-…

2a4c0d9

…1437

kraftbj requested a review from Copilot April 16, 2026 16:45

Copilot started reviewing on behalf of kraftbj April 16, 2026 16:46 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

docs: fix comment and README for store subpath externalization

f41ab5b

kraftbj requested a review from Copilot April 16, 2026 20:26

Copilot started reviewing on behalf of kraftbj April 16, 2026 20:27 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread projects/packages/assets/src/class-shared-extension-utils-assets.php

fix: skip CSS registration for shared-extension-utils UMD

4e9a6b4

kraftbj requested a review from Copilot April 16, 2026 20:40

Copilot started reviewing on behalf of kraftbj April 16, 2026 20:41 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

kraftbj marked this pull request as ready for review April 16, 2026 20:52

kraftbj requested a review from a team as a code owner April 16, 2026 20:52

kraftbj requested a review from jeherve April 16, 2026 20:52

kraftbj added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 16, 2026

manzoorwanijk reviewed Apr 17, 2026

View reviewed changes

Comment thread projects/js-packages/connection/state/store-holder.jsx

Comment thread projects/js-packages/connection/state/store-holder.jsx Outdated

anomiex reviewed Apr 17, 2026

View reviewed changes

Merge remote-tracking branch 'origin/trunk' into investigate-jetpack-…

9c4e3a3

…1437 # Conflicts: # projects/packages/assets/package.json

kraftbj marked this pull request as draft April 17, 2026 21:00

kraftbj added [Status] In Progress and removed [Status] Needs Review This PR is ready for review. labels Apr 17, 2026

refactor: complete shared-extension-utils externalization

30741fc

github-actions bot added the [Extension] AI Assistant Plugin label Apr 17, 2026

kraftbj changed the title ~~Externalize shared-extension-utils to fix duplicate store registration~~ Complete shared-extension-utils externalization to prevent duplicate store registration Apr 17, 2026

Conversation

kraftbj commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Uh oh!

github-actions bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anomiex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kraftbj commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kraftbj commented Mar 30, 2026 •

edited

Loading

github-actions bot commented Mar 30, 2026 •

edited

Loading

github-actions bot commented Mar 30, 2026 •

edited

Loading

jp-launch-control bot commented Mar 30, 2026 •

edited

Loading