Reapply: Rename Advertising to Blaze Ads, add context-aware menu and campaign promotion by jjolmo · Pull Request #47858 · Automattic/jetpack

jjolmo · 2026-03-31T09:20:43Z

⚠️ Reproduction branch — this reapplies the original #47582 changes (reverted in #47856) without fixes, to reproduce and debug the Simple Sites menu regression.

Proposed changes:

Renames the "Advertising" menu item to "Blaze Ads" and makes the menu placement context-aware across all installation types. When a site has active campaigns, the menu is promoted to a top-level entry for better visibility.

Changes in `jetpack-blaze` package:

Rename all user-facing "Advertising" labels to "Blaze Ads"
Add get_menu_parent() for context-aware parent menu selection: WooCommerce Marketing (with menu existence guard) > Jetpack > Tools fallback
Add has_active_campaigns() with 1-hour transient cache for campaign detection via WPCOM DSP API
Promote to top-level add_menu_page() when active campaigns exist (both dashboard-enabled and WPCOM non-dashboard paths)
Update Dashboard and Dashboard_Config_Data constructor defaults from tools.php to admin.php
Update get_campaign_management_url() to use admin.php?page=advertising
Add redirect_legacy_advertising_url() (302 redirect from tools.php?page=advertising)

Changes in `jetpack-mu-wpcom` package:

Remove advertising from Tools submenu reorder array
Add advertising to Jetpack submenu reorder array

Changes in Jetpack plugin:

Fix stale tools.php?page=advertising URL in blaze.jsx settings panel

Other information:

Generate changelog entries for this PR (using AI).

Related product discussion/links

Does this pull request change what data or activity we track or use?

No. The campaign detection API call uses the existing WPCOM DSP proxy and results are cached in a transient. No new tracking is introduced.

Testing instructions:

Context-aware menu placement (no campaigns):

On a WPCOM/Jetpack site: verify "Blaze Ads" appears under Jetpack menu
On a WooCommerce + Jetpack site: verify "Blaze Ads" appears under Marketing menu
On a self-hosted + Jetpack site (no Woo): verify "Blaze Ads" appears under Jetpack menu

Top-level promotion (with campaigns):

On any site with active Blaze campaigns: verify "Blaze Ads" appears as a top-level menu item with megaphone icon
Flush the transient (delete_transient('jetpack_blaze_has_active_campaigns_{blog_id}')) to verify state transitions

Legacy URL redirect:

Navigate to tools.php?page=advertising and verify it 302-redirects to admin.php?page=advertising

Dashboard functionality:

Verify the Blaze dashboard loads and hash-based routing works in all menu positions
Verify "Promote with Blaze" row action on posts list still works

🤖 Jurassic Ninja Test Results (2026-04-01)

Test matrix

#	Environment	Campaigns	Expected Menu Location	Actual Menu Location	Dashboard Loads	Legacy Redirect	Result
1	JN + Jetpack (no Woo)	No	Jetpack → Blaze Ads	Jetpack → Blaze Ads	✅	✅ `tools.php` → `admin.php`	✅ PASS
2	JN + Jetpack (no Woo)	Yes (transient)	Top-level Blaze Ads	Top-level Blaze Ads	✅	✅	✅ PASS
3	JN + Jetpack + WooCommerce	No	Marketing → Blaze Ads	Marketing → Blaze Ads	✅	✅ `tools.php` → `admin.php`	✅ PASS
4	JN + Jetpack + WooCommerce	Yes (transient)	Top-level Blaze Ads	Top-level Blaze Ads	✅	✅	✅ PASS

Test sites used

No WooCommerce: registered-haddock-lemur.jurassic.ninja
With WooCommerce: bird-of-rabbits.jurassic.ninja

Notes

Branch: javiolmo89/ads-796-blaze-ads-menu-repro installed via Jetpack Beta Tester
Campaign detection tested by setting transient jetpack_blaze_has_site_campaigns_{blog_id} to yes (the DSP API does not immediately return campaigns in moderation as active, so transient simulation was used)
Campaign creation flow tested end-to-end on site 1 (campaign submitted successfully, appears in Campaigns tab as "In moderation")
Legacy URL redirect (tools.php?page=advertising → admin.php?page=advertising) verified on both sites
Blaze dashboard loads correctly in all menu positions with hash-based routing working

…campaign promotion Cherry-pick of fa1c1a3 (original PR #47582) on top of trunk (which includes the revert). No fixes applied — this branch exists solely to reproduce the Simple Sites menu regression reported in #47856. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-31T09:21:37Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the javiolmo89/ads-796-blaze-ads-menu-repro branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack javiolmo89/ads-796-blaze-ads-menu-repro

bin/jetpack-downloader test jetpack-mu-wpcom-plugin javiolmo89/ads-796-blaze-ads-menu-repro

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-03-31T09:21:48Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2026-03-31T09:34:17Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/blaze/src/class-dashboard-rest-controller.php	698/775 (90.06%)	0.04%	0 💚
projects/packages/blaze/src/class-blaze.php	166/235 (70.64%)	15.69%	-13 💚

Full summary · PHP report · JS report

…tection Simple Sites have two issues with the menu changes from #47582: 1. has_site_campaigns() always returns false because it uses Client::wpcom_json_api_request_as_user() which relies on Jetpack Signature — unavailable on Simple Sites. Switch to request_as_blog() which uses WPCOM_API_Direct on Simple Sites (no HTTP round-trip). 2. The embedded dashboard (admin.php?page=advertising) under the 'jetpack' parent menu is not routable by the WPCOM admin bridge on Simple Sites — it falls back to /home/. Fix by using the external Calypso URL (https://wordpress.com/advertising/...) on Simple Sites, matching the pattern used by every other Jetpack submenu item. Also skip the legacy tools.php → admin.php redirect on Simple Sites since admin.php?page=advertising is not routable there. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

On Simple Sites the WPCOM admin bridge only routes tools.php?page=… URLs. Changing the dashboard base to admin.php (needed for Jetpack/Woo parent menus on Atomic and self-hosted) breaks Simple Sites because admin.php?page=advertising falls back to /home/. Fix: detect Simple Sites (IS_WPCOM) and keep tools.php as the dashboard base while still using the new parent menu and campaign detection logic. Also keep request_as_blog for has_site_campaigns() since it uses WPCOM_API_Direct on Simple Sites (no HTTP round-trip needed). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Temporary error_log to trace which code branch executes on Simple Sites. Logs: parent_slug, is_simple, dashboard_enabled, has_campaigns, wpcom_admin_interface. Remove before merging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Clean up temporary error_log from investigation. Fix all Generic.Formatting.MultipleStatementAlignment warnings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Restore self::has_site_campaigns() call lost during debug cleanup - Fix equals sign alignment in get_campaign_management_url Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

On Simple Sites the WPCOM admin bridge only routes tools.php?page=… URLs. Registering under a plugin parent (jetpack, woocommerce-marketing) produces admin.php?page=… which the bridge cannot route. Fix: on Simple Sites, register the actual page callback under tools.php (so the URL is routable), then hide it from the Tools menu and add a visible link under the Jetpack parent (or top-level) pointing to the tools.php URL. This gives us the desired menu placement while keeping the page functional. Non-Simple sites (Atomic, self-hosted) are unaffected — they use admin.php?page=… directly which works fine with any parent menu. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Simple Sites can use admin.php?page=slug like every other environment. Remove the $is_simple_site branching that registered the page under tools.php and pointed menu items to it. Now all environments share the same code path: add_menu_page / add_submenu_page with the slug directly. The legacy redirect (tools.php?page=advertising → admin.php) now also applies on Simple Sites so old bookmarks keep working. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The WPCOM platform branch was using the Calypso URL as the menu slug, which in wp-admin got rewritten to wp-admin/advertising (broken). Now it uses the same slug and render callback as the dashboard-enabled branch, so the menu correctly points to admin.php?page=advertising. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

On Simple Sites, the Jetpack top-level menu is created at priority 1000 by Admin_Menu::admin_menu_hook_callback(), but Blaze registers its submenu at priority 999. When add_submenu_page('jetpack', ...) is called before the parent menu exists, WordPress computes the wrong page hookname (admin_page_advertising instead of jetpack_page_advertising). This causes the menu link href to be just "advertising" instead of "admin.php?page=advertising", resulting in a broken URL. Fix: Use Admin_Menu::add_menu() (the same pattern Social uses) when registering under the Jetpack parent. This queues the item and registers it at priority 1000, after the top-level menu exists. For other parents (tools.php, woocommerce-marketing) that exist at priority 999, keep using add_submenu_page directly. Also consolidate the is_dashboard_enabled and is_wpcom_platform branches which contained identical logic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

When the parent is 'jetpack', the menu item is now queued via Admin_Menu::add_menu() instead of added directly to $submenu. The test needs to call Admin_Menu::admin_menu_hook_callback() to flush the queue before checking $submenu. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

sbarbosa

I tested this on an ephemeral site, an atomic and simple site. I added some comments for the ephemeral test.

I was not able to validate the Root-level link on my atomic site. I still see it under Jetpack, and that's my main site (I have 200+ campaigns in there). I created a new campaign to see if that worked, but the menu is still under Jetpack.

All of my simple sites already have campaigns, but I was able to see the link at the root level and it worked fine for me.

sbarbosa · 2026-04-01T16:26:36Z

+	 *
+	 * @return string The parent menu slug.
+	 */
+	public static function get_menu_parent() {


If we add the menu this way, there will be problems if the Blaze Ads plugin is also installed on the site:

The Blaze Ads plugin currently hides the Jetpack Dashboard and also includes the link on the Marketing page.

We had the is_dashboard_enabled condition here before, so I think the new changes are not currently checking for it. If the dashboard is disabled, we shouldn't put the menu anywhere.

If we want Blaze Ads to always be present in Marketing when running alongside Woo (regardless of whether Blaze Ads is installed), I think it's only possible by checking here whether the plugin is installed and, if it is, ignoring adding it (to prevent duplicate menus).

Sounds good. I'll add the condition. We can still modify blaze-ads to behave how we want. I think the blaze-ads plugin feels very redundant when user has WooCommerce. I'll think about it, but I can see a lot of redundancy here. For now, i'll check if the user got the plugin. good catch!

jjolmo · 2026-04-01T16:58:03Z

I tested this on an ephemeral site, an atomic and simple site. I added some comments for the ephemeral test.

I was not able to validate the Root-level link on my atomic site. I still see it under Jetpack, and that's my main site (I have 200+ campaigns in there). I created a new campaign to see if that worked, but the menu is still under Jetpack.
All of my simple sites already have campaigns, but I was able to see the link at the root level and it worked fine for me.

Thanks so much for testing it!

just curious. I'm not able to replicate the issue. But by ephemeral site, what do you mean? Would a "jurassic.ninja" site be considered "ephemeral"? I might need to add it to the matrix, but first I need to understand the environment

sbarbosa · 2026-04-01T18:10:33Z

Thanks so much for testing it!

just curious. I'm not able to replicate the issue. But by ephemeral site, what do you mean? Would a "jurassic.ninja" site be considered "ephemeral"? I might need to add it to the matrix, but first I need to understand the environment

Yes, ephemeral sites are just those short-lived sites that JN and other tools create. I tested it with JN, so you should be able to reproduce it.

For the JN test, I did this:
1- Created a site with this branch as the base version for jetapck
2- Tested the link position on the menu
3- Installed WooCommerce and tested that the menu appeared under Marketing
4- Install Blaze Ads and tested the same but noticed the duplication

All plugin versions are from production (only the ones being pulled from dotorg).

For the atomic test, I just installed Jetpack Beta on my atomic site and tested it with this specific branch version.

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 31, 2026

jjolmo added the [Status] In Progress label Mar 31, 2026

jjolmo and others added 13 commits March 31, 2026 11:57

Fix PHPCS alignment warnings in class-blaze.php

4625e1d

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Remove debug logging and fix PHPCS alignment

ed0721d

Clean up temporary error_log from investigation. Fix all Generic.Formatting.MultipleStatementAlignment warnings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Fix undefined variable and PHPCS alignment

130bd92

- Restore self::has_site_campaigns() call lost during debug cleanup - Fix equals sign alignment in get_campaign_management_url Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Fix PHPCS alignment warnings in get_campaign_management_url

35fe3f0

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add changelog entry for race condition fix

e83b793

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jjolmo self-assigned this Apr 1, 2026

jjolmo requested review from sbarbosa and therocket-gr April 1, 2026 11:00

jjolmo and others added 2 commits April 1, 2026 13:08

Fix menu label: remove debug 'Test 2' suffix from 'Blaze Ads'

5b2d20d

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Trigger CI: re-run code coverage check

d19e993

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

sbarbosa reviewed Apr 1, 2026

View reviewed changes

jjolmo marked this pull request as draft April 14, 2026 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reapply: Rename Advertising to Blaze Ads, add context-aware menu and campaign promotion#47858

Reapply: Rename Advertising to Blaze Ads, add context-aware menu and campaign promotion#47858
jjolmo wants to merge 16 commits intotrunkfrom
javiolmo89/ads-796-blaze-ads-menu-repro

jjolmo commented Mar 31, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

jp-launch-control bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

sbarbosa left a comment

Uh oh!

sbarbosa Apr 1, 2026

Uh oh!

jjolmo Apr 1, 2026

Uh oh!

jjolmo commented Apr 1, 2026

Uh oh!

sbarbosa commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jjolmo commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Changes in jetpack-blaze package:

Changes in jetpack-mu-wpcom package:

Changes in Jetpack plugin:

Other information:

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions:

Context-aware menu placement (no campaigns):

Top-level promotion (with campaigns):

Legacy URL redirect:

Dashboard functionality:

🤖 Jurassic Ninja Test Results (2026-04-01)

Test matrix

Test sites used

Notes

Uh oh!

github-actions bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

sbarbosa left a comment

Choose a reason for hiding this comment

Uh oh!

sbarbosa Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

jjolmo Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

jjolmo commented Apr 1, 2026

Uh oh!

sbarbosa commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jjolmo commented Mar 31, 2026 •

edited

Loading

Changes in `jetpack-blaze` package:

Changes in `jetpack-mu-wpcom` package:

github-actions bot commented Mar 31, 2026 •

edited

Loading

github-actions bot commented Mar 31, 2026 •

edited

Loading

jp-launch-control bot commented Mar 31, 2026 •

edited

Loading