Skip to content

Forms: update empty state to use component from wp-ui#47908

Draft
simison wants to merge 3 commits intotrunkfrom
update/forms-empty-state
Draft

Forms: update empty state to use component from wp-ui#47908
simison wants to merge 3 commits intotrunkfrom
update/forms-empty-state

Conversation

@simison
Copy link
Copy Markdown
Member

@simison simison commented Apr 2, 2026

Resolves FORMS-674

Proposed changes

  • Uses EmptyState recently added to wp-ui.
  • Adds icons to each empty state

Other information

  • Generate changelog entries for this PR (using AI).

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Try empty forms lists and empty responses lists

@simison simison added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Package] Forms labels Apr 2, 2026
"@wordpress/route": "0.8.0",
"@wordpress/theme": "0.9.0",
"@wordpress/ui": "0.9.0",
"@wordpress/ui": "0.10.0",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally updated before this PR everywhere to the same version via #47907

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Apr 2, 2026

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/components/empty-responses/index.tsx 0/44 (0.00%) 0.00% -2 💚

Full summary · PHP report · JS report

@simison simison force-pushed the update/forms-empty-state branch from 89c48e8 to 8adeb2e Compare April 3, 2026 14:26
@simison simison requested review from a team, dhasilva and enejb April 3, 2026 15:05
@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 3, 2026

Still needs more work:

  • Form icon doesn't show up
  • The PR messes up Forms canvas styles somehow

@enejb
Copy link
Copy Markdown
Member

enejb commented Apr 3, 2026

I also notice on mobile it looks like this.

Screenshot 2026-04-03 at 4 22 17 PM

But didn't dig in why.

@simison simison force-pushed the update/forms-empty-state branch from 8adeb2e to d6af659 Compare April 6, 2026 07:21
@enejb enejb force-pushed the update/forms-empty-state branch from d6af659 to 5cdbba8 Compare April 10, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Package] Forms [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants