Sidebar upsell: add Tracks event#47937

Merged

simison merged 15 commits intotrunkfrom

update/sidebar-upsell-tracks

Apr 6, 2026

Member

simison commented Apr 3, 2026 •

edited

Loading

Follow-up to #47418

Proposed changes

Adds Tracks event for the upgrade nudge

Other information

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Build the script with jetpack build packages/admin-ui
Site without free plan (or modify should_show_upgrade_menu() temporarily to return true)
Click upsell menu in sidebar
To see Tracks events, enter localStorage.setItem( 'debug', '*' ); in console. For more methods see PCYsg-cae-p2

simison mentioned this pull request

Admin UI: Add Upgrade Jetpack menu item for free users #47418

Merged

4 tasks

simison added the [Status] In Progress label

simison self-assigned this

Contributor

github-actions bot commented Apr 3, 2026 •

edited

Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/sidebar-upsell-tracks branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/sidebar-upsell-tracks

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/sidebar-upsell-tracks

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions bot added [Package] Admin Ui [Tests] Includes Tests labels

Contributor

github-actions bot commented Apr 3, 2026 •

edited

Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Beta plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Mu Wpcom plugin:

Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Inspect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Automattic For agencies client plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Classic Theme helper plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Paypal Payment buttons plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcloud Sso plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control bot commented Apr 3, 2026 •

edited

Loading

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/admin-ui/src/class-admin-menu.php	129/154 (83.77%)	2.81%	1 ❤️‍🩹

Full summary · PHP report · JS report

_{Coverage check overridden by

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR
.}

simison force-pushed the update/sidebar-upsell-tracks branch from 791e91b to 2a40c6d Compare

April 6, 2026 08:22

simison commented

View reviewed changes

projects/packages/admin-ui/src/admin-ui-upgrade-menu.js Outdated Show resolved Hide resolved

simison added 6 commits

April 6, 2026 12:15


          Sidebar upsell: add Tracks event

82ab1b1


          remove debug code


          Target a element

38ec844


          Remove debug code

de7a880


          Use more modern Tracks pixel library and add more tracks props

8026fb1


          Add "seen" event

46e6ae1

simison force-pushed the update/sidebar-upsell-tracks branch from e6c9fda to 46e6ae1 Compare

April 6, 2026 09:15

simison added 2 commits

April 6, 2026 17:09


          Only record "seen" event when submenu is open

f6c5b32


          Cleaner PHP & simplify without "seen" event

5824a7b

simison marked this pull request as ready for review

April 6, 2026 14:49

simison added the Coverage tests to be added later label


          Split the style & JS bundles separate

2abb1b7

CGastrell reviewed

View reviewed changes

projects/packages/admin-ui/src/admin-ui-upgrade-menu-tracking.js Outdated Show resolved Hide resolved

projects/packages/admin-ui/src/class-admin-menu.php Show resolved Hide resolved

simison and others added 3 commits

April 6, 2026 18:22


          Safer caller and native DOMContentLoaded to simplify.

fa69847


          Declare jetpack-connection as dev dep to satisfy Phan

The Tracks enqueue path uses \Automattic\Jetpack\Tracking,
\Jetpack_Options, and \Jetpack_Tracks_Client behind class_exists()
guards. All three classes live in the connection package. Declaring
it as a test-only dev dependency lets Phan's static analysis resolve
them without making connection a hard runtime requirement — the
class_exists() guards continue to protect standalone consumers that
don't ship the connection package.


          Update plugin composer.lock files for admin-ui dev dep

64eaa04

Regenerate the 16 plugin lock files to record the new
jetpack-connection require-dev entry and test-only dependency
reference added to packages/admin-ui in 9721412. No
functional changes beyond the admin-ui reference hash bump.

github-actions bot added [Plugin] Automattic For Agencies Client [Plugin] Backup [Plugin] Beta [Plugin] Boost labels

github-actions bot added [Plugin] Classic Theme Helper Plugin [Plugin] Inspect [Plugin] Jetpack [Plugin] mu wpcom [Plugin] Paypal Payment Buttons [Plugin] Protect [Plugin] Search [Plugin] Social [Plugin] Starter Plugin [Plugin] VideoPress [Plugin] Wpcloud Sso [Plugin] Wpcomsh labels

simison added 3 commits

April 6, 2026 19:06


          Remove dom-ready dep

84bcea1


          Changelogs

83cc582


          Boost changelog

3e3123e

simison merged commit d387845 into trunk

88 checks passed

simison deleted the update/sidebar-upsell-tracks branch

April 6, 2026 17:00

github-actions bot removed the [Status] In Progress label

This was referenced Apr 6, 2026

Sidebar upsell: add "seen" event #47954

Draft

Sidebar upsell: make event prop names lowercase #47955

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Coverage tests to be added later [Package] Admin Ui [Plugin] Automattic For Agencies Client [Plugin] Backup [Plugin] Beta [Plugin] Boost [Plugin] Classic Theme Helper Plugin [Plugin] Inspect [Plugin] Jetpack [Plugin] mu wpcom [Plugin] Paypal Payment Buttons [Plugin] Protect [Plugin] Search [Plugin] Social [Plugin] Starter Plugin [Plugin] VideoPress [Plugin] Wpcloud Sso [Plugin] Wpcomsh [Tests] Includes Tests