Admin page component: add isolation style for wp-ui popovers

[simison]

Now that we're using @wordpress/ui in all headers of Admin UI as well as in other places of Jetpack UI, let's set up popovers properly as instructed in the package readme.

Proposed changes

• Adds isolation styles to help portaled popovers from @wordpress/ui to appear correctly.

See https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/isolation

See setup:

Also, to ensure that portaled popovers appear correctly, add these isolation styles to your application's layout root element:

.root {
 isolation: isolate;
}

No before/after since we're not using popovers yet from @wordpress/ui, but it's easy to miss this setup rule for anyone later adding them.

Other information

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

• Jetpack pages continue to work

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/page-isolation-styles branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/page-isolation-styles

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/page-isolation-styles

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

[ciampo]

I don't have much context on how the project is structured: is .admin-page the root DOM node of the React app?

[simison]

Not exactly, but admin-page is the lowest node shared by all pages.

Is that a critical difference here?

[ciampo]

It doesn't need to be the DOM root, it just needs to be the outermost wrapper of the app content. In this case, I think .admin-page is good.

But I'd feel safer adding a code comment about those styles needing to be on the outermost wrapper of the app content — it may help in future refactors.

[simison]

BTW docs should probably note that "Within WordPress" is actually just within WP Build pages (root style), but fully custom pages built within WP Admin still need the styles added?

[ciampo]

Good point, I'll work on an update

[ciampo]

WordPress/gutenberg#77338

[ciampo]

Another aspect that is recommended in the base ui docs (and we should include in our docs, too) is to add position: relative to the body element.

[ciampo]

We updated https://github.com/WordPress/gutenberg/blob/trunk/packages/ui/README.md#setup to refect this information, too